Add PP tracer + DP test #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Merged
kwen2501
added a commit
that referenced
this pull request
Jun 1, 2024
ghstack-source-id: e26b222d093e1405277e45f42d93f05e58286980 Pull Request resolved: #379
facebook-github-bot
added
the
CLA Signed
|
CI should pass after pytorch/pytorch#127607 is landed. |
awgu
reviewed
Jun 3, 2024
Comment on lines
+427
to
+429
| # Q1: what is the contract of `fully_shard`? Would it transform | ||
| # module in place? @awgu indicates that it would. Then, we shouldn't | ||
| # need to register the module with its parent again. |
Comment on lines
+430
to
+433
| # Q2: does this requirement come from Activation Checkpointing, and | ||
| # maybe this line too? | ||
| # `transformer_block = torch.compile(transformer_block`) | ||
| # If that's the case, should this line be moved above to after AC? |
There was a problem hiding this comment.
I think both of these lines included module wrappers, so AC and compile are the reasons why we have to reassign the module into the parent.
transformer_block = checkpoint_wrapper(transformer_block, ac_config)
transformer_block = torch.compile(transformer_block, dynamic=False)
There was a problem hiding this comment.
I think your point is good though. I think we have some unnecessary assignments back to the parent module here.
kwen2501
added a commit
that referenced
this pull request
Jun 3, 2024
ghstack-source-id: e26b222d093e1405277e45f42d93f05e58286980 Pull Request resolved: #379
tianyu-l
force-pushed
the
gh/kwen2501/4/base
branch
from
8de2449 to
8f6cf62
Compare
tianyu-l
force-pushed
the
gh/kwen2501/4/head
branch
from
4f9bad3 to
490652c
Compare
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: e26b222d093e1405277e45f42d93f05e58286980 Pull Request resolved: #379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Separate the addition of 2D test from original PR #362 for easier review and landing.
Also changed
.items()tonamed_children()for more general submodule access. See similar changes in #371.