Use general way to access and update submodules #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
kwen2501
added a commit
that referenced
this pull request
Jun 3, 2024
ghstack-source-id: ba1d77e5825a26632fe9b7509a88b44509cac45f Pull Request resolved: #381
tianyu-l
pushed a commit
to tianyu-l/torchtitan_intern24
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: ba1d77e5825a26632fe9b7509a88b44509cac45f Pull Request resolved: pytorch#381
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: ba1d77e5825a26632fe9b7509a88b44509cac45f Pull Request resolved: #381
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
ghstack-source-id: ba1d77e5825a26632fe9b7509a88b44509cac45f Pull Request resolved: pytorch#381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR fixes the issue mentioned pytorch/pytorch#126653 (comment):
"Module object has no attributed items."
The reason is, a split ModuleDict is no longer a ModuleDict.
It would be more generally applicable if we use named_children() and register_module() to access and update submodules.