Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add annotations-to-metadata transformer #318

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

misialq
Copy link
Collaborator

@misialq misialq commented Apr 3, 2024

This PR adds two transformers:

  • eggnog annotations -> Metadata
  • eggnog annotations -> pd.DataFrame

to allow viewing the FeatureData[NOG] artifacts using metadata tabulate.

Additionally, it adds the annotation_dict method on OrthologAnnotationDirFmt to simplify retrieval of sample/MAG IDs and path to their respective annotation files.

@misialq
Copy link
Collaborator Author

misialq commented Apr 3, 2024

Hey @ebolyen, @Oddant1 - could you have a look? If we merge this soon, we could potentially make use of that in our Monday workshop session...

@lizgehret
Copy link
Member

@misialq and I discussed this in person - the general PR itself seems fine, but a bigger question is whether or not this transformer's functionality in the context of the associated visualization makes sense and is digestible for users. We will most likely refactor this in the future once we have a better approach for this.

@lizgehret lizgehret merged commit d24a69d into qiime2:dev Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants