Mise en place de la traduction de l'interface contributeur #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the title
raphodn
approved these changes
Feb 14, 2023
app/settings.py
Outdated
| @@ -71,6 +73,7 @@ | |||
| "solo", # django-solo | |||
| "dal", # django-autocomplete-light | |||
| "dal_select2", | |||
| "rosetta", | |||
There was a problem hiding this comment.
je vais enlever "rosetta", pour qu'on le fasse dans une PR séparée
app/urls.py
Outdated
|
|
||
| from core.admin import admin_site | ||
|
|
||
|
|
||
| urlpatterns = [ | ||
| urlpatterns = i18n_patterns( |
There was a problem hiding this comment.
je pense qu'il y aura des urls qui n'auront pas besoin du prefix (comme api ou stats)
There was a problem hiding this comment.
j'ai réorganisé les urls ici : c06f639
app/settings.py
Outdated
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| import dj_database_url | |||
| import sentry_sdk | |||
| from django.utils.translation import gettext_lazy as gettext_lazy | |||
There was a problem hiding this comment.
Suggested change
| from django.utils.translation import gettext_lazy as gettext_lazy | |
| from django.utils.translation import gettext_lazy as _ |
app/settings.py
Outdated
| @@ -54,6 +55,7 @@ | |||
| "django.contrib.sessions", | |||
| "django.contrib.messages", | |||
| "django.contrib.staticfiles", | |||
| "django.utils.translation", | |||
There was a problem hiding this comment.
je ne crois pas que cette ligne soit nécessaire
| @@ -5,14 +5,16 @@ | |||
| {% block title %}Liste des administrateurs{{ block.super }}{% endblock %} | |||
|
|
|||
| {% block breadcrumbs %} | |||
| {% load i18n %} | |||
There was a problem hiding this comment.
tout en haut du fichier plutôt ? 🤔
raphodn
force-pushed
the
contributor-interface-translation
branch
from
bb495f9
to
c06f639
Compare
|
ok j'ai fixé un conflit avec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A noter:
PR a utiliser (après review) pour une démo.
Seulement quelques templates html ont été traduits. Il reste encore pas mal de boulot.