-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve e2e tests & fix sorting bug #1575
Conversation
- the order of the sort object is important, but react-query hashes items in the query key and so differently ordered objects are considered equal So JSON stringify the sort object when passed as a query key param
- Remove linting errors - Delete unneeded tests - Improve efficiency by consolidating tests into fewer, longer tests (see https://docs.cypress.io/guides/references/best-practices#Creating-Tiny-Tests-With-A-Single-Assertion) - lint the cypress code in the CI job
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1575 +/- ##
===========================================
- Coverage 96.28% 96.20% -0.08%
===========================================
Files 161 161
Lines 6869 6885 +16
Branches 2129 2139 +10
===========================================
+ Hits 6614 6624 +10
- Misses 235 240 +5
- Partials 20 21 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
- multiple filters didn't work, it only ever checked the first filter
- Add tests for bugs I found - Fix linting errors - Improve test efficiency - Lint cypress code in CI
- Ensure cypress code is linted in CI - Fixed linting errors - Small refactor for increased efficiency
…ded in download status table Thanks to @kaperoo for finding this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the bug described are fixed. code LGTM
Description
(see https://docs.cypress.io/guides/references/best-practices#Creating-Tiny-Tests-With-A-Single-Assertion)
Testing instructions
Add a set up instructions describing how the reviewer should test the code