Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve e2e tests & fix sorting bug #1575

Merged
merged 13 commits into from
Aug 24, 2023
Merged

Improve e2e tests & fix sorting bug #1575

merged 13 commits into from
Aug 24, 2023

Commits on Aug 18, 2023

  1. Fix sorting bug in useQuery hooks 

    - the order of the sort object is important, but react-query
hashes items in the query key and so differently ordered objects are considered equal
So JSON stringify the sort object when passed as a query key param
    @louise-davies
    louise-davies committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c3e4b0d View commit details
    Browse the repository at this point in the history

  2. Improve cypress e2e tests 

    - Remove linting errors
- Delete unneeded tests
- Improve efficiency by consolidating tests into fewer, longer tests
(see https://docs.cypress.io/guides/references/best-practices#Creating-Tiny-Tests-With-A-Single-Assertion)
- lint the cypress code in the CI job
    @louise-davies
    louise-davies committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    98769bb View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Fix bug where formatted columns couldn't be sorted in adminDownloadSt… 

    …atusTable
    @louise-davies
    louise-davies committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    396a66e View commit details
    Browse the repository at this point in the history

  2. Fix multi-column filtering bug in downloadStatusTable 

    - multiple filters didn't work, it only ever checked the first filter
    @louise-davies
    louise-davies committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f74f581 View commit details
    Browse the repository at this point in the history

  3. Improve download e2e tests 

    - Add tests for bugs I found
- Fix linting errors
- Improve test efficiency
- Lint cypress code in CI
    @louise-davies
    louise-davies committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f692e7a View commit details
    Browse the repository at this point in the history

  4. Debug failing cypress test on CI

    @louise-davies
    louise-davies committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    4a5acd1 View commit details
    Browse the repository at this point in the history

  5. Fix download e2e test that only passed when progress bars were enabled

    @louise-davies
    louise-davies committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    51c2e90 View commit details
    Browse the repository at this point in the history

  6. Fix dataPublications table test broken due to date differences on CI … 

    …and SG preprod
    @louise-davies
    louise-davies committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    ac1125f View commit details
    Browse the repository at this point in the history

  7. Fix CI detection in dataview e2e tests

    @louise-davies
    louise-davies committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8cb85bc View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Improve dg search tests 

    - Ensure cypress code is linted in CI
- Fixed linting errors
- Small refactor for increased efficiency
    @louise-davies
    louise-davies committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9cba537 View commit details
    Browse the repository at this point in the history

  2. Debug search card view test

    @louise-davies
    louise-davies committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6fc4e4c View commit details
    Browse the repository at this point in the history

  3. Fix card view pagination test on CI

    @louise-davies
    louise-davies committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f4ff158 View commit details
    Browse the repository at this point in the history

  4. Fix unhandled exception thrown when invalid datetime ranges are provi… 

    …ded in download status table

Thanks to @kaperoo for finding this one!
    @louise-davies
    louise-davies committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0ff8da5 View commit details
    Browse the repository at this point in the history