-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FutureWarning of UCX < 1.11.1 deprecation #779
Add FutureWarning of UCX < 1.11.1 deprecation #779
Conversation
I'm not necessarily tied to this idea, but perhaps we should start warning users of UCX < 1.11.1 deprecation? Also it doesn't need to be right now, we could delay it for 21.12 or another RAPIDS release. |
I'm not against deprecating but I think the sentiment you raised around waiting a bit is probably correct. However, I don't know of anyone using UCX-Py who can't upgrade UCX |
It's not too much on upgrading or not, but fundamentally older UCX (such as 1.9) lacked a lot of functionality that are now implemented in UCX 1.11.1 (e.g., automatic IB device detection, IB allocation registration cache, endpoint error handling with CUDA IPC) that really simplifies things for us by a lot, and removing that code sometime in the near future would be great. Therefore, alerting users would probably be a good first step, also to hear from users who can't potentially upgrade rather sooner than later. |
This is just adding a warning right? Not actually dropping anything. Think it makes sense to get this in sooner rather than later. It will give us flexibility later on when deciding whether we want to drop or not. The longer we wait to communicate this to users, the longer it takes for us to actually do the deprecation, which may come at a point where things are more painful |
That said, it's probably worth raising this with key stakeholders first just so they are aware and we can make any changes to the deprecation schedule if needed. |
cc @dantegd @cjnolet for cuML |
Hi all, What do you recommend for a "quick" check ? Build ucx-py 1.11.1 in a stand alone environment and run the test suite ? |
@benjha yes, it would be good to run UCX-Py and Dask-CUDA tests if you can:
EDIT: For the async UCX-Py API I've added |
I've also checked with DLFW folks offline, and they're already running some RC version of UCX 1.11.1, so dropping compatibility code isn't a problem for them, as that only affects UCX 1.9 and older. |
How do we feel about merging this? |
Since no objections were raised in over 2 months, I'll plan to merge this later today. We'll discuss a plan to completely drop support for UCX < 1.11.1 early next year. |
rernu tests |
rerun tests |
I'm doing some final testing, will merge this tomorrow or Monday. |
After rapidsai/ucx-py#779 , this is required to run pytests when using UCX 1.9. To be removed in a future release. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - https://github.com/jakirkham URL: #799
Besides stability, UCX 1.11.1 includes important features such as:
UCX_NET_DEVICES
explicitly;All features above will simplify usage both with and without Dask and RAPIDS. Therefore, we would like to deprecate older versions of UCX, to be removed at a later release.