Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FutureWarning of UCX < 1.11.1 deprecation #779

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Add FutureWarning of UCX < 1.11.1 deprecation #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
817a932
Add FutureWarning of UCX < 1.11.1 deprecation
pentschev Sep 9, 2021
438826f
Add deprecation note to UCX 1.9 docs
pentschev Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/source/install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ Instructions for building UCX 1.11.1:
make -j install


UCX-1.9
~~~~~~~
UCX-1.9 (Deprecated)
~~~~~~~~~~~~~~~~~~~~

Instructions for building ucx 1.9:

Expand Down Expand Up @@ -131,7 +131,7 @@ As noted above, the UCX conda package no longer builds support for IB/RDMA. To

If OFED drivers are not installed on the machine, you can download drivers at directly from `Mellanox <https://www.mellanox.com/products/infiniband-drivers/linux/mlnx_ofed>`_. For versions older than 5.1 click on, *archive versions*.

Building UCX 1.9 or 1.11 as shown previously should automatically include IB/RDMA support if available in the system. It is possible to explicitly activate those, ensuring the system satisfies all dependencies or fail otherwise, by including the ``--with-rdmacm`` and ``--with-verbs`` build flags. For example:
Building UCX 1.11.1 or 1.9 (deprecated) as shown previously should automatically include IB/RDMA support if available in the system. It is possible to explicitly activate those, ensuring the system satisfies all dependencies or fail otherwise, by including the ``--with-rdmacm`` and ``--with-verbs`` build flags. For example:

::

Expand Down
8 changes: 8 additions & 0 deletions ucp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import logging
import os
import warnings

from ._version import get_versions as _get_versions
from .core import * # noqa
Expand Down Expand Up @@ -40,3 +41,10 @@

__version__ = _get_versions()["version"]
__ucx_version__ = "%d.%d.%d" % get_ucx_version()

if get_ucx_version() < (1, 11, 1):
warnings.warn(
f"Support for UCX {__ucx_version__} is deprecated, it's highly recommended "
"upgrading to 1.11.1 or newer.",
FutureWarning,
)