Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageProfile unit tests #2288

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

raaizik
Copy link
Contributor

@raaizik raaizik commented Nov 28, 2023

Unit tests covering StorageProfile API

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@raaizik raaizik force-pushed the sp-tests-main branch 5 times, most recently from 506ca2c to 3953ae0 Compare November 28, 2023 17:13
@raaizik raaizik changed the title [main] StorageProfile unit tests StorageProfile unit tests Nov 28, 2023
@raaizik raaizik marked this pull request as ready for review November 28, 2023 17:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2023
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 16, 2023
@raaizik raaizik force-pushed the sp-tests-main branch 14 times, most recently from 1c91311 to 6abfcb7 Compare December 20, 2023 11:26
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2024
@raaizik
Copy link
Contributor Author

raaizik commented Jan 22, 2024

/unassign @nb-ohad @leelavg

@raaizik
Copy link
Contributor Author

raaizik commented Jan 22, 2024

/cc @nb-ohad

@openshift-ci openshift-ci bot requested a review from nb-ohad January 22, 2024 11:15
@raaizik raaizik requested a review from rewantsoni January 25, 2024 10:31
@raaizik raaizik force-pushed the sp-tests-main branch 6 times, most recently from b81c3ef to a48b66e Compare January 25, 2024 11:00
@raaizik raaizik requested review from jarrpa and rchikatw January 25, 2024 11:02
@raaizik
Copy link
Contributor Author

raaizik commented Jan 25, 2024

/test ocs-operator-bundle-e2e-aws

raaizik and others added 2 commits January 29, 2024 19:23
- Cephfs tests added for cases of provider and non-provider modes
- storageclassrequests tests added

Signed-off-by: raaizik <[email protected]>
Co-authored-by: Jose A. Rivera <[email protected]>
Signed-off-by: raaizik <[email protected]>
Co-authored-by: Jose A. Rivera <[email protected]>
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, and now that that's cleaned up, let's FINISH THIS.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, raaizik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2ef8a88 into red-hat-storage:main Jan 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants