Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports the cluster's name #2534

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

raaizik
Copy link
Contributor

@raaizik raaizik commented Mar 28, 2024

RHSTOR-5500
Expands the StorageConsumer's status to include the cluster's name which will then be exposed to the GUI back-end service.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@raaizik raaizik marked this pull request as ready for review March 28, 2024 10:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@raaizik raaizik force-pushed the export-name branch 3 times, most recently from 3379dbe to 1b474ae Compare March 28, 2024 10:41
@raaizik
Copy link
Contributor Author

raaizik commented Mar 28, 2024

/cc @leelavg @nb-ohad

@openshift-ci openshift-ci bot requested review from leelavg and nb-ohad March 28, 2024 10:56
@rchikatw
Copy link
Contributor

rchikatw commented Apr 1, 2024

changes look ok to me.

Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please expand the PR summary and description, rest lg.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
@nb-ohad
Copy link
Contributor

nb-ohad commented Apr 1, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad, raaizik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4689ec0 into red-hat-storage:main Apr 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants