Syncing latest changes from main for ramen #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing about regional DR in the script, it is just a helper to run without a timeout and enabling verbose mode. Signed-off-by: Nir Soffer <[email protected]>
It easier to type and more consistent. Nobody uses camelCase in option names. Signed-off-by: Nir Soffer <[email protected]>
When working on e2e or api we need a way to run lint quickly without running complex golangci-lint command manually. Signed-off-by: Nir Soffer <[email protected]>
Fix random test failures if the placement was modified after we got it:
actions_test.go:31: Operation cannot be fulfilled on
placements.cluster.open-cluster-management.io "appset-deploy-cephfs-busybox": the
object has been modified; please apply your changes to the latest version and try
again
Fixes: RamenDR#1593
Signed-off-by: Nir Soffer <[email protected]>
It was returning both placement and placementDecsision name which is not helpful since we have a helper to return a placement. Signed-off-by: Nir Soffer <[email protected]>
Fix random failures like:
actions_test.go:53: Operation cannot be fulfilled on
drplacementcontrols.ramendr.openshift.io "subscr-deploy-rbd-busybox":
the object has been modified; please apply your changes to the latest
version and try again
Signed-off-by: Nir Soffer <[email protected]>
Syncing latest changes from upstream main for ramen
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from main branch