Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing latest changes from main for ramen #383

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Syncing latest changes from main for ramen #383

merged 7 commits into from
Oct 28, 2024

Commits on Oct 23, 2024

  1. Rename test script 

    There is nothing about regional DR in the script, it is just a helper to
run without a timeout and enabling verbose mode.

Signed-off-by: Nir Soffer <[email protected]>
    @nirs @raghavendra-talur
    nirs authored and raghavendra-talur committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9b849ad View commit details
    Browse the repository at this point in the history

  2. Rename e2e -configFile to -config 

    It easier to type and more consistent. Nobody uses camelCase in option
names.

Signed-off-by: Nir Soffer <[email protected]>
    @nirs @raghavendra-talur
    nirs authored and raghavendra-talur committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    dace2c1 View commit details
    Browse the repository at this point in the history

  3. Add lint-e2e and lint-api targets 

    When working on e2e or api we need a way to run lint quickly without
running complex golangci-lint command manually.

Signed-off-by: Nir Soffer <[email protected]>
    @nirs @raghavendra-talur
    nirs authored and raghavendra-talur committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b54eaec View commit details
    Browse the repository at this point in the history

  4. Handle conflicts when updating placement 

    Fix random test failures if the placement was modified after we got it:

    actions_test.go:31: Operation cannot be fulfilled on
    placements.cluster.open-cluster-management.io "appset-deploy-cephfs-busybox": the
    object has been modified; please apply your changes to the latest version and try
    again

Fixes: RamenDR#1593
Signed-off-by: Nir Soffer <[email protected]>
    @nirs @raghavendra-talur
    nirs authored and raghavendra-talur committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f2ba011 View commit details
    Browse the repository at this point in the history

  5. Simplify waitPlacementDecision 

    It was returning both placement and placementDecsision name which is not
helpful since we have a helper to return a placement.

Signed-off-by: Nir Soffer <[email protected]>
    @nirs @raghavendra-talur
    nirs authored and raghavendra-talur committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ec7c087 View commit details
    Browse the repository at this point in the history

  6. Handle conflicts when starting failover or relocate 

    Fix random failures like:

    actions_test.go:53: Operation cannot be fulfilled on
    drplacementcontrols.ramendr.openshift.io "subscr-deploy-rbd-busybox":
    the object has been modified; please apply your changes to the latest
    version and try again

Signed-off-by: Nir Soffer <[email protected]>
    @nirs @raghavendra-talur
    nirs authored and raghavendra-talur committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    797475c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge pull request #381 from red-hat-storage/sync_us--main 

    Syncing latest changes from upstream main for ramen
    @ShyamsundarR
    ShyamsundarR authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bab2799 View commit details
    Browse the repository at this point in the history