-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename controller-manager to controller #883
Rename controller-manager to controller #883
Conversation
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because this changes the deployment name in the CSV, it should allow for OLM upgrades despite the change in label selectors. Upstream-Commit: b156020
3374e8a
to
b71324e
Compare
/retest |
@qbarrand: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
3318a85
into
rh-ecosystem-edge:main
/cherry-pick release-2.0 |
@qbarrand: #883 failed to apply on top of branch "release-2.0":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Because this changes the deployment name in the CSV, it should allow for OLM upgrades despite the change in label selectors.
Fixes #882
/cc @yevgeny-shnaidman @ybettan