Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename controller-manager to controller #883

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -166,22 +166,22 @@ spec:
- subjectaccessreviews
verbs:
- create
serviceAccountName: kmm-operator-hub-controller-manager
serviceAccountName: kmm-operator-hub-controller
deployments:
- label:
app.kubernetes.io/component: kmm-hub
app.kubernetes.io/name: kmm-hub
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
name: kmm-operator-hub-controller-manager
control-plane: controller
name: kmm-operator-hub-controller
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/component: kmm-hub
app.kubernetes.io/name: kmm-hub
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
control-plane: controller
strategy: {}
template:
metadata:
Expand All @@ -191,11 +191,11 @@ spec:
app.kubernetes.io/component: kmm-hub
app.kubernetes.io/name: kmm-hub
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
control-plane: controller
spec:
containers:
- args:
- --config=controller_manager_config.yaml
- --config=controller_config.yaml
command:
- /usr/local/bin/manager
env:
Expand Down Expand Up @@ -247,9 +247,9 @@ spec:
- mountPath: /etc/pki/ca-trust/extracted/pem
name: trusted-ca
readOnly: true
- mountPath: /controller_manager_config.yaml
- mountPath: /controller_config.yaml
name: manager-config
subPath: controller_manager_config.yaml
subPath: controller_config.yaml
- args:
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
Expand Down Expand Up @@ -279,7 +279,7 @@ spec:
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault
serviceAccountName: kmm-operator-hub-controller-manager
serviceAccountName: kmm-operator-hub-controller
terminationGracePeriodSeconds: 10
tolerations:
- effect: NoSchedule
Expand Down Expand Up @@ -332,7 +332,7 @@ spec:
- update
- patch
- delete
serviceAccountName: kmm-operator-hub-controller-manager
serviceAccountName: kmm-operator-hub-controller
strategy: deployment
installModes:
- supported: true
Expand Down Expand Up @@ -361,7 +361,7 @@ spec:
- admissionReviewVersions:
- v1
containerPort: 443
deploymentName: kmm-operator-hub-controller-manager
deploymentName: kmm-operator-hub-controller
failurePolicy: Fail
generateName: vmanagedclustermodule.kb.io
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ metadata:
app.kubernetes.io/component: kmm-hub
app.kubernetes.io/name: kmm-hub
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
name: kmm-operator-hub-controller-manager-metrics-service
control-plane: controller
name: kmm-operator-hub-controller-metrics-service
spec:
ports:
- name: https
Expand All @@ -18,6 +18,6 @@ spec:
app.kubernetes.io/component: kmm-hub
app.kubernetes.io/name: kmm-hub
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
control-plane: controller
status:
loadBalancer: {}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
data:
controller_manager_config.yaml: |
controller_config.yaml: |
healthProbeBindAddress: :8081
metricsBindAddress: 127.0.0.1:8080
webhookPort: 9443
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ spec:
app.kubernetes.io/component: kmm-hub
app.kubernetes.io/name: kmm-hub
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
control-plane: controller
status:
loadBalancer: {}
Original file line number Diff line number Diff line change
Expand Up @@ -301,22 +301,22 @@ spec:
- subjectaccessreviews
verbs:
- create
serviceAccountName: kmm-operator-controller-manager
serviceAccountName: kmm-operator-controller
deployments:
- label:
app.kubernetes.io/component: kmm
app.kubernetes.io/name: kmm
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
name: kmm-operator-controller-manager
control-plane: controller
name: kmm-operator-controller
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/component: kmm
app.kubernetes.io/name: kmm
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
control-plane: controller
strategy: {}
template:
metadata:
Expand All @@ -326,11 +326,11 @@ spec:
app.kubernetes.io/component: kmm
app.kubernetes.io/name: kmm
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
control-plane: controller
spec:
containers:
- args:
- --config=controller_manager_config.yaml
- --config=controller_config.yaml
command:
- /usr/local/bin/manager
env:
Expand Down Expand Up @@ -384,9 +384,9 @@ spec:
- mountPath: /etc/pki/ca-trust/extracted/pem
name: trusted-ca
readOnly: true
- mountPath: /controller_manager_config.yaml
- mountPath: /controller_config.yaml
name: manager-config
subPath: controller_manager_config.yaml
subPath: controller_config.yaml
- args:
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
Expand Down Expand Up @@ -416,7 +416,7 @@ spec:
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault
serviceAccountName: kmm-operator-controller-manager
serviceAccountName: kmm-operator-controller
terminationGracePeriodSeconds: 10
tolerations:
- effect: NoSchedule
Expand Down Expand Up @@ -469,7 +469,7 @@ spec:
- update
- patch
- delete
serviceAccountName: kmm-operator-controller-manager
serviceAccountName: kmm-operator-controller
- rules:
- apiGroups:
- security.openshift.io
Expand Down Expand Up @@ -518,7 +518,7 @@ spec:
- admissionReviewVersions:
- v1
containerPort: 443
deploymentName: kmm-operator-controller-manager
deploymentName: kmm-operator-controller
failurePolicy: Fail
generateName: vmodule.kb.io
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ metadata:
app.kubernetes.io/component: kmm
app.kubernetes.io/name: kmm
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
name: kmm-operator-controller-manager-metrics-monitor
control-plane: controller
name: kmm-operator-controller-metrics-monitor
spec:
endpoints:
- bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
Expand All @@ -17,4 +17,4 @@ spec:
insecureSkipVerify: true
selector:
matchLabels:
control-plane: controller-manager
control-plane: controller
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ metadata:
app.kubernetes.io/component: kmm
app.kubernetes.io/name: kmm
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
name: kmm-operator-controller-manager-metrics-service
control-plane: controller
name: kmm-operator-controller-metrics-service
spec:
ports:
- name: https
Expand All @@ -18,6 +18,6 @@ spec:
app.kubernetes.io/component: kmm
app.kubernetes.io/name: kmm
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
control-plane: controller
status:
loadBalancer: {}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
data:
controller_manager_config.yaml: |
controller_config.yaml: |
healthProbeBindAddress: :8081
metricsBindAddress: 127.0.0.1:8080
leaderElection:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ spec:
app.kubernetes.io/component: kmm
app.kubernetes.io/name: kmm
app.kubernetes.io/part-of: kmm
control-plane: controller-manager
control-plane: controller
status:
loadBalancer: {}
2 changes: 1 addition & 1 deletion ci/install-ci-spoke/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ patchesStrategicMerge:
apiVersion: apps/v1
kind: Deployment
metadata:
name: controller-manager
name: controller
namespace: system
spec:
template:
Expand Down
4 changes: 2 additions & 2 deletions ci/prow/e2e-hub-spoke-incluster-build
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ if [ "$SKIP_MAKE_DEPLOY_HUB" == true ]; then
else
echo "Deploy KMMO-Hub..."
make deploy-hub KUSTOMIZE_CONFIG_HUB_DEFAULT=ci/install-ci-hub
oc wait --for=condition=Available --timeout=1m deployment/kmm-operator-hub-controller-manager -n ${OPERATOR_NAMESPACE}
oc wait --for=condition=Available --timeout=1m deployment/kmm-operator-hub-controller -n ${OPERATOR_NAMESPACE}
fi

if [ "$SKIP_MAKE_DEPLOY" == true ]; then
echo "Skipping KMM deployment"
else
echo "Deploy KMM..."
make deploy KUSTOMIZE_CONFIG_DEFAULT=ci/install-ci-spoke
oc wait --for=condition=Available --timeout=1m deployment/kmm-operator-controller-manager -n ${OPERATOR_NAMESPACE}
oc wait --for=condition=Available --timeout=1m deployment/kmm-operator-controller -n ${OPERATOR_NAMESPACE}
fi

# Apply the ManagedClusterModule
Expand Down
2 changes: 1 addition & 1 deletion ci/prow/e2e-incluster-build
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ oc apply -f ci/kmm-kmod-dockerfile.yaml
echo "Add Secrets containing the signing key and certificate..."
oc apply -f ci/secret_kmm-kmod-signing.yaml

oc wait --for=condition=Available deployment/kmm-operator-controller-manager -n openshift-kmm
oc wait --for=condition=Available deployment/kmm-operator-controller -n openshift-kmm

echo "Add an kmm-ci Module that contains a valid mapping..."
oc apply -f ci/module-kmm-ci-build-sign.yaml
Expand Down
2 changes: 1 addition & 1 deletion config/default-hub/kustomizeconfig.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namePrefix:
- kind: Deployment
name: controller-manager
name: controller
path: spec/template/spec/volumes/secret/secretName
2 changes: 1 addition & 1 deletion config/default-hub/manager_webhook_patch.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: controller-manager
name: controller
namespace: system
spec:
template:
Expand Down
2 changes: 1 addition & 1 deletion config/default/kustomizeconfig.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namePrefix:
- kind: Deployment
name: controller-manager
name: controller
path: spec/template/spec/volumes/secret/secretName
2 changes: 1 addition & 1 deletion config/default/manager_webhook_patch.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: controller-manager
name: controller
namespace: system
spec:
template:
Expand Down
12 changes: 6 additions & 6 deletions config/manager-base/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,29 @@ apiVersion: v1
kind: Namespace
metadata:
labels:
control-plane: controller-manager
control-plane: controller
security.openshift.io/scc.podSecurityLabelSync: 'true'
openshift.io/cluster-monitoring: "true"
name: system
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: controller-manager
name: controller
namespace: system
labels:
control-plane: controller-manager
control-plane: controller
spec:
selector:
matchLabels:
control-plane: controller-manager
control-plane: controller
replicas: 1
template:
metadata:
annotations:
kubectl.kubernetes.io/default-container: manager
labels:
control-plane: controller-manager
control-plane: controller
spec:
affinity:
nodeAffinity:
Expand Down Expand Up @@ -74,7 +74,7 @@ spec:
requests:
cpu: 10m
memory: 64Mi
serviceAccountName: controller-manager
serviceAccountName: controller
terminationGracePeriodSeconds: 10
tolerations:
- key: node-role.kubernetes.io/master
Expand Down
4 changes: 2 additions & 2 deletions config/manager-base/manager_auth_proxy_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: controller-manager
name: controller
namespace: system
spec:
template:
Expand All @@ -30,4 +30,4 @@ spec:
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop: [ALL]
drop: [ALL]
8 changes: 4 additions & 4 deletions config/manager-base/manager_config_patch.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: controller-manager
name: controller
namespace: system
spec:
template:
spec:
containers:
- name: manager
args:
- "--config=controller_manager_config.yaml"
- "--config=controller_config.yaml"
volumeMounts:
- name: manager-config
mountPath: /controller_manager_config.yaml
subPath: controller_manager_config.yaml
mountPath: /controller_config.yaml
subPath: controller_config.yaml
volumes:
- name: manager-config
configMap:
Expand Down
Loading
Loading