Address github comments

Signed-off-by: Dmitriy Ryabtsev <[email protected]>
riscv · Sep 26, 2024 · 858f63d · 858f63d
1 parent 8062e5e
commit 858f63d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/adoc_event_tables/spec.adoc b/adoc_event_tables/spec.adoc
@@ -2,11 +2,11 @@
 [width="100%",cols="30%,70%",options="header",]
 |===
 |Name |Description
-|INST.ISSUED |Number of instructions issued
-|INST.LOAD.ISSUED |Number of memory load instructions issued
-|INST.STORE.ISSUED |Number of memory store instructions issued
-|INST.INT.ISSUED |Number of integer instructions issued
-|INST.FPU.ISSUED |Number of FPU instructions issued
-|UOP.ISSUED |Number of micro-operations issued
+|INST.SPEC |Number of instructions issued
+|INST.LOAD.SPEC |Number of memory load instructions issued
+|INST.STORE.SPEC |Number of memory store instructions issued
+|INST.INT.SPEC |Number of integer instructions issued
+|INST.FPU.SPEC |Number of FPU instructions issued
+|UOP.SPEC |Number of micro-operations issued
 |===
 
diff --git a/adoc_event_tables/topdown_metrics.adoc b/adoc_event_tables/topdown_metrics.adoc
@@ -3,7 +3,7 @@
 |===
 |Name |Description |Formula
 |TOPDOWN.SLOTS |For implementations which do not provide TOPDOWN.SLOTS as explicit event it is possible to calculate it as metric using CYCLES.HART event. |pipeline_width * CYCLES.HART
-|TOPDOWN.BAD_SPECULATION.SLOTS |For implementations which do not provide TOPDOWN.BAD_SPECULATION.SLOTS as explicit event it is possible to calculate it as metric. It consiste of two part - the number of cancelled operations (UOP.ISSUED - UOP.RET) and the number of slots wasted on recovery from pipeline flush (pipeline_width * PRD.PIPELINE_FLUSH.RECOVERY_CYCLES) |UOP.ISSUED - UOP.RET + pipeline_width * PRD.PIPELINE_FLUSH.RECOVERY_CYCLES
+|TOPDOWN.BAD_SPECULATION.SLOTS |For implementations which do not provide TOPDOWN.BAD_SPECULATION.SLOTS as explicit event it is possible to calculate it as metric. It consiste of two part - the number of cancelled operations (UOP.SPEC - UOP.RET) and the number of slots wasted on recovery from pipeline flush (pipeline_width * PRD.PIPELINE_FLUSH.RECOVERY_CYCLES) |UOP.SPEC - UOP.RET + pipeline_width * PRD.PIPELINE_FLUSH.RECOVERY_CYCLES
 |TOPDOWN.BACKEND_BOUND.CORE.SLOTS |For implementations which do not provide TOPDOWN.BACKEND_BOUND.CORE.SLOTS as explicit event it is possible to calculate it as metric by subtracting memory bound slots from all backend bound slots |TOPDOWN.BACKEND_BOUND.SLOTS - TOPDOWN.BACKEND_BOUND.MEMORY.SLOTS
 |TOPDOWN.BAD_SPECULATION |Fraction of slots wasted due to incorrect speculations. This include slots used to issue uops that do not eventually get retired and slots for which the issue-pipeline was blocked due to recovery from earlier incorrect speculation. |TOPDOWN.BAD_SPECULATION.SLOTS / TOPDOWN.SLOTS
 |TOPDOWN.BAD_SPECULATION.MISPRED.RATE |Fraction of slots wasted due to incorrect control flow speculations |TOPDOWN.BAD_SPECULATION.MISPRED.SLOTS / TOPDOWN.SLOTS

diff --git a/event_files/spec.json b/event_files/spec.json
@@ -1,36 +1,36 @@
 [
     {
-        "EventName": "INST.ISSUED",
+        "EventName": "INST.SPEC",
         "EventCode": "0x0",
         "BriefDescription": "Number of instructions issued",
         "PublicDescription": "Number of instructions issued"
     },
     {
-        "EventName": "INST.LOAD.ISSUED",
+        "EventName": "INST.LOAD.SPEC",
         "EventCode": "0x0",
         "BriefDescription": "Number of memory load instructions issued",
         "PublicDescription": "Number of memory load instructions issued"
     },
     {
-        "EventName": "INST.STORE.ISSUED",
+        "EventName": "INST.STORE.SPEC",
         "EventCode": "0x0",
         "BriefDescription": "Number of memory store instructions issued",
         "PublicDescription": "Number of memory store instructions issued"
     },
     {
-        "EventName": "INST.INT.ISSUED",
+        "EventName": "INST.INT.SPEC",
         "EventCode": "0x0",
         "BriefDescription": "Number of integer instructions issued",
         "PublicDescription": "Number of integer instructions issued"
     },
     {
-        "EventName": "INST.FPU.ISSUED",
+        "EventName": "INST.FPU.SPEC",
         "EventCode": "0x0",
         "BriefDescription": "Number of FPU instructions issued",
         "PublicDescription": "Number of FPU instructions issued"
     },
     {
-        "EventName": "UOP.ISSUED",
+        "EventName": "UOP.SPEC",
         "EventCode": "0x0",
         "BriefDescription": "Number of micro-operations issued",
         "PublicDescription": "Number of micro-operations issued"

diff --git a/event_files/topdown_metrics.json b/event_files/topdown_metrics.json
@@ -7,8 +7,8 @@
     },
     {
         "MetricName": "TOPDOWN.BAD_SPECULATION.SLOTS",
-        "BriefDescription": "For implementations which do not provide TOPDOWN.BAD_SPECULATION.SLOTS as explicit event it is possible to calculate it as metric. It consiste of two part - the number of cancelled operations (UOP.ISSUED - UOP.RET) and the number of slots wasted on recovery from pipeline flush (pipeline_width * PRD.PIPELINE_FLUSH.RECOVERY_CYCLES)",
-        "MetricExpr": "UOP.ISSUED - UOP.RET + pipeline_width * PRD.PIPELINE_FLUSH.RECOVERY_CYCLES"
+        "BriefDescription": "For implementations which do not provide TOPDOWN.BAD_SPECULATION.SLOTS as explicit event it is possible to calculate it as metric. It consiste of two part - the number of cancelled operations (UOP.SPEC - UOP.RET) and the number of slots wasted on recovery from pipeline flush (pipeline_width * PRD.PIPELINE_FLUSH.RECOVERY_CYCLES)",
+        "MetricExpr": "UOP.SPEC - UOP.RET + pipeline_width * PRD.PIPELINE_FLUSH.RECOVERY_CYCLES"
     },
     {
         "MetricName": "TOPDOWN.BACKEND_BOUND.CORE.SLOTS",