Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx blog linking and taxonomies #244

Merged
merged 7 commits into from
Oct 30, 2023
Merged

FIx blog linking and taxonomies #244

merged 7 commits into from
Oct 30, 2023

Conversation

drmowinckels
Copy link
Member

@drmowinckels drmowinckels commented Oct 7, 2023

changes should be visible in

  • /tags
  • /categories
  • and links in the awesome blog list

@drmowinckels drmowinckels requested a review from a team as a code owner October 7, 2023 08:14
@drmowinckels
Copy link
Member Author

should be rebased on merge, as long as we dont tamper much more with it .

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

🎉 The preview is built! Check it out

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

🎉 The preview is built! Check it out

@github-actions
Copy link

🎉 The preview is built! Check it out

@cosimameyer
Copy link
Contributor

Just a quick question for clarification: I see that we have now working links for the awesome R-Ladies’ list (that’s fantastic! 🥳) but I don’t see a difference with the categories/tags. Can you show me an example of what to expect?

I was also a bit confused by the name of the word-cloud because I expected it to format an actual wordcloud (but couldn’t find one). Or am I missing something?

@drmowinckels
Copy link
Member Author

so, I think for tags it looks ok, and its not a proper wordcloud, because I did not want to bother with adding a whole js thing, so its pure html and css.

https://244--rladies-dev.netlify.app/tags/
image

but for categories it looks absolutely crazy, because the rladies category just has so many uses....
https://244--rladies-dev.netlify.app/categories/
image

@drmowinckels
Copy link
Member Author

but we need to have a look through tags and categories and clean the posts up a little. We've not had a super clear and enforced policy on tags/category usage, so we should do that maybe even before this PR #243 ?

@drmowinckels
Copy link
Member Author

ok. I went away from the wordcloud, to not overcomplicate things. I rather opted for a simple flexbox with terms and counters next to them

image

@github-actions
Copy link

🎉 The preview is built! Check it out

@github-actions
Copy link

🎉 The preview is built! Check it out

@cosimameyer
Copy link
Contributor

Sorry for taking so long here, the last weeks were a bit crazy. I'm okay with merging - I believe @SoyAndrea's review is missing 🙌

@drmowinckels drmowinckels merged commit fce2689 into main Oct 30, 2023
3 checks passed
@drmowinckels drmowinckels deleted the bloglink branch October 30, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants