Merge rm control on 2023 engineer. #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rm-control ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
所有ui经过测试了吗 |
|
@L-SY 看一下代码，没啥问题我就先merge了。 |
|
任何时候master分支的代码都不应该有“某某代码没合并”就出问题这种极其抽象的情况。更何况原有的代码和新的msg有什么关系。 |
|
“说是”“猜测”，你就这么相信他的判断啊 |
那你先单独开个msgs的pr，先单独合并msgs，把UI的问题找到再说 @cc0h |
主要是pr就因为这种问题卡在这。我个人认为merge之后再测，如果还有这个问题，改了再重新pr也没关系 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge engineer ui codes.
Add can lose error in rm_hw.