[ROMM-994] Autogenerated collections #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamantike
reviewed
Feb 10, 2025
Comment on lines
+118
to
+120
| array_to_json(array_agg(rom_id)) as rom_ids, | ||
| array_to_json(array_agg(path_cover_s)) as path_covers_s, | ||
| array_to_json(array_agg(path_cover_l)) as path_covers_l |
There was a problem hiding this comment.
This differs from MySQL, where we use DISTINCT within the aggregation. I don't think that's needed as I don't see a way for CTEs to repeat rom_id values. We should have the same logic for both engines.
There was a problem hiding this comment.
i can't seem to figure out how to DISTINCT in postgres like i did in mysql 🤷🏼
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very excited about this one! This PR creates a virtual database table that collects and groups games based on certain IGDB metadata fields: collections, franchises, genres, companies and modes. The list of virtual
VirtualCollectionscan be fetched and filtered by type, and displayed in the home screen and collections sidebar. Editing these virtual collections is not possible, so controls like the collection editor window are hidden.As we add more metadata providers, we can update the virtual table to pull properties outside
igdb_metadata.TODO
Related Issues
Closes #994
Checklist
Please check all that apply.
Screenshots