Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Improve memory allocation with buffer variables #1801

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

This PR tries to address the issue of memory allocation in the RT loop of the CM read, write, and update cycles

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@4eabd25). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../include/controller_manager/controller_manager.hpp 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1801   +/-   ##
=========================================
  Coverage          ?   87.26%           
=========================================
  Files             ?      121           
  Lines             ?    12091           
  Branches          ?     1077           
=========================================
  Hits              ?    10551           
  Misses            ?     1149           
  Partials          ?      391           
Flag Coverage Δ
unittests 87.26% <97.05%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 76.99% <100.00%> (ø)
.../include/controller_manager/controller_manager.hpp 96.66% <91.66%> (ø)

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fair. Is there a reason that you went for a quite large number to reserve memory for?

@gavanderhoorn
Copy link

Question: would using an RT-safe memory allocator not be a more scalable approach?

Copy link
Contributor

mergify bot commented Oct 17, 2024

This pull request is in conflict. Could you fix it @saikishor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants