-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Improve memory allocation with buffer variables #1801
base: master
Are you sure you want to change the base?
[CM] Improve memory allocation with buffer variables #1801
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1801 +/- ##
=========================================
Coverage ? 87.26%
=========================================
Files ? 121
Lines ? 12091
Branches ? 1077
=========================================
Hits ? 10551
Misses ? 1149
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fair. Is there a reason that you went for a quite large number to reserve memory for?
Question: would using an RT-safe memory allocator not be a more scalable approach? |
This pull request is in conflict. Could you fix it @saikishor? |
This PR tries to address the issue of memory allocation in the RT loop of the CM
read
,write
, andupdate
cycles