-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle SIGINT properly in the controller manager #2014
Handle SIGINT properly in the controller manager #2014
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
+ Coverage 89.37% 89.38% +0.01%
==========================================
Files 132 132
Lines 14649 14683 +34
Branches 1261 1269 +8
==========================================
+ Hits 13092 13124 +32
+ Misses 1091 1086 -5
- Partials 466 473 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tested with
Not comprehensive testing, but the issue was fixed and I didn't notice any side effects 👍 |
@mjforan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
resolves #2012
resolves #1168
resolves #472
Needed by ros-controls/ros2_control_demos#548
With example_1 of ros2_control_demos: