Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Method Typo #125

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Correct Method Typo #125

merged 1 commit into from
Dec 6, 2023

Conversation

Deleh
Copy link
Contributor

@Deleh Deleh commented Dec 4, 2023

Stumbled across this one.

mehtod -> method

@hoffmann-stefan
Copy link
Member

CI is failing because of new empy release which needs to be pinned in colcon.
As setup-ros 0.7.1 doesn't support foxy anymore, we need to look if we should create our own fork of the action to support foxy as well.

https://github.com/ros-tooling/setup-ros/releases/tag/0.7.1

@hoffmann-stefan
Copy link
Member

The fix was back-ported to [email protected], so this builds again 🎉: ros-tooling/setup-ros#634

hoffmann-stefan
hoffmann-stefan approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@hoffmann-stefan hoffmann-stefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fix 👍

@hoffmann-stefan hoffmann-stefan merged commit 40adb43 into ros2-dotnet:main Dec 6, 2023
5 checks passed
@Deleh Deleh deleted the fix/typo branch December 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmann-stefan hoffmann-stefan hoffmann-stefan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Deleh @hoffmann-stefan