-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/image performance #128
base: main
Are you sure you want to change the base?
Feature/image performance #128
Commits on Apr 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9401929 - Browse repository at this point
Copy the full SHA 9401929View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52363eb - Browse repository at this point
Copy the full SHA 52363ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4eeb2c - Browse repository at this point
Copy the full SHA e4eeb2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb0f23f - Browse repository at this point
Copy the full SHA cb0f23fView commit details -
Named {member}_Count as this is the normal .NET lingo. removed getsize_array_field c function as well as it is constant, no need for interop
Configuration menu - View commit details
-
Copy full SHA for 2b198f4 - Browse repository at this point
Copy the full SHA 2b198f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8209665 - Browse repository at this point
Copy the full SHA 8209665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0820c78 - Browse repository at this point
Copy the full SHA 0820c78View commit details -
Initialize arrays and change mapped type
Idl arrays now map as System.Array instead of List<T>. This is the more natural C# type for them.
Configuration menu - View commit details
-
Copy full SHA for fb9a25f - Browse repository at this point
Copy the full SHA fb9a25fView commit details -
Add size checks for array and bounded sequences
- size gets checked on writing to the native handle of the message. - change foreach to for to avoid multi threaded race conditions while writing to native memory. (the upper bound is now local and cannot be changed from somewhere else)
Configuration menu - View commit details
-
Copy full SHA for 922c24d - Browse repository at this point
Copy the full SHA 922c24dView commit details -
Use
int32_t
as size type to the c# side`List<T>.Count` is of c# type `int`, wich is 32 bit signed. C does use `sizeof_t` wich is 32/64 bit dependent. So this does marshal at least correctly, ignoring cast from 64 bit to 32 bit and vice versa for now. getting marshaling/conversations 100% correct is anoher issue for another day.
Configuration menu - View commit details
-
Copy full SHA for 7dc4f12 - Browse repository at this point
Copy the full SHA 7dc4f12View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebbd965 - Browse repository at this point
Copy the full SHA ebbd965View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2229e71 - Browse repository at this point
Copy the full SHA 2229e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41f46a0 - Browse repository at this point
Copy the full SHA 41f46a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8722462 - Browse repository at this point
Copy the full SHA 8722462View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e8521d - Browse repository at this point
Copy the full SHA 1e8521dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c21977 - Browse repository at this point
Copy the full SHA 0c21977View commit details -
Configuration menu - View commit details
-
Copy full SHA for 262ffea - Browse repository at this point
Copy the full SHA 262ffeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 680e3db - Browse repository at this point
Copy the full SHA 680e3dbView commit details -
Remove Interfaces that expose internal implementation details
Most importent the `IntPtr Handle` property from `ROS2.Interfaces.IDisposable` should not be public. `ROS2.Interfaces.IDisposable` was missleading as well. (`System.IDisposable` is the well kown one) Made appropriate memers internal as well and added some sealed and static modifiers. This was done in preperation for adding SafeHandles to avoid memory leaks, as this would change the implementation detail that was made public by the interfaces. Abstractions such as interfaces have to be designed for extensability. See https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/abstractions-abstract-types-and-interfaces
Configuration menu - View commit details
-
Copy full SHA for bd37a93 - Browse repository at this point
Copy the full SHA bd37a93View commit details -
Add SafeHandles for Node and related types
As of before this commit native recources for rcl_node_t, rcl_client_t, rcl_publisher_t, rcl_service_t and rcl_subscription_t didn't get released. Used a trick from dotnet/runtime to handle the requirement that node has to be released last. Also added some TODOs to check return values and for checks near allocations use the new throw helper.
Configuration menu - View commit details
-
Copy full SHA for a65e5e9 - Browse repository at this point
Copy the full SHA a65e5e9View commit details -
Add SafeHandles for request id and wait set
- Refactored and renamed some methods to be more consistent. - Added some error handling. - Don't try to take things if the wait set did return a timeout.
Configuration menu - View commit details
-
Copy full SHA for 3b33504 - Browse repository at this point
Copy the full SHA 3b33504View commit details -
Add SafeHandles to generated message types
- renamed IMessage to IRosMessage - moved interfaces for generated types to ROS2 namespace - renamed interface members - used `global::*` in some places to avoid name colisions - added editor browsable never to the members of the interfaces that schould not be used outside of rcldotnet
Configuration menu - View commit details
-
Copy full SHA for ca71795 - Browse repository at this point
Copy the full SHA ca71795View commit details -
- Avoids doing reflection over and over. - If we can require static abstract interface members this could go away.
Configuration menu - View commit details
-
Copy full SHA for c3d3797 - Browse repository at this point
Copy the full SHA c3d3797View commit details -
- move RCLExeptionHelper from rcldotnet_common to rcldotnet for acces to rcl_get_error_string() - get error string using rcl_get_error_string() and add this to the exception message - change throw helper to avoid unrachable code - also some other cleanup
Configuration menu - View commit details
-
Copy full SHA for f87e169 - Browse repository at this point
Copy the full SHA f87e169View commit details -
Rename request variable to solve a CS0136 error:
error CS0136: A local or parameter named 'request' cannot be declared in this scope because that name is used in an enclosing local scope to define a local or parameter
Configuration menu - View commit details
-
Copy full SHA for 91f8e01 - Browse repository at this point
Copy the full SHA 91f8e01View commit details -
Use
const
instead ofstatic readonly
for constantsThis allows them to be used in switch cases and other places.
Configuration menu - View commit details
-
Copy full SHA for 67a732b - Browse repository at this point
Copy the full SHA 67a732bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 849eca5 - Browse repository at this point
Copy the full SHA 849eca5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79a338d - Browse repository at this point
Copy the full SHA 79a338dView commit details
Commits on Jun 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 06f231e - Browse repository at this point
Copy the full SHA 06f231eView commit details
Commits on Jun 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fe31b3f - Browse repository at this point
Copy the full SHA fe31b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d3790b - Browse repository at this point
Copy the full SHA 6d3790bView commit details -
reduce warnings: Only use cdecl calling convention on i386 architectures
This removes a warning when compiling on x64 plattforms. The C# DllImportAttribute ignores this calling canvention as well, but dosn't give a warning.
Configuration menu - View commit details
-
Copy full SHA for a337ee5 - Browse repository at this point
Copy the full SHA a337ee5View commit details -
reduce warnings: remove debug message in cmake script
Removes stderr output on build.
Configuration menu - View commit details
-
Copy full SHA for 73975d2 - Browse repository at this point
Copy the full SHA 73975d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b51d27 - Browse repository at this point
Copy the full SHA 6b51d27View commit details -
codestyle: Format code using
dotnet format
This was done with an temporary *.csproj file in the root of the repository: ```xml <Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <TargetFramework>netstandard2.0</TargetFramework> </PropertyGroup> </Project> ``` Then run command `dotnet format` (from .NET6) in the root of the repository. Did some manual whitespace changes as well, mainly indented wrapped parameters.
Configuration menu - View commit details
-
Copy full SHA for 534d2a3 - Browse repository at this point
Copy the full SHA 534d2a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc68df1 - Browse repository at this point
Copy the full SHA fc68df1View commit details -
Configuration menu - View commit details
-
Copy full SHA for be8439d - Browse repository at this point
Copy the full SHA be8439dView commit details
Commits on Jun 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 093c045 - Browse repository at this point
Copy the full SHA 093c045View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7713c5 - Browse repository at this point
Copy the full SHA b7713c5View commit details
Commits on Jun 21, 2022
-
guard conditions: only try to take waitables if they are ready
This avoids doing unnecessary allocations of native ROS messages only to check that there is no new data. This might be a good thing to do right now as with guard_conditions there could be probably more times the waitset is ready to fire some callbacks, so work should be minimized here especially.
Configuration menu - View commit details
-
Copy full SHA for 664ee0b - Browse repository at this point
Copy the full SHA 664ee0bView commit details
Commits on Jun 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for adebb26 - Browse repository at this point
Copy the full SHA adebb26View commit details
Commits on Jun 23, 2022
-
actions: extend idl generation to include interfaces for "action wrap…
…per types" With "action wrapper types" this means the ROS messages and services that add the `GoalId`, `TimeStamp` or other fields on top of the user defined types for the action. The introduced methods in `IRosActionDefinition` are needed to work around the missing existential type support in C# (dotnet/csharplang#5556).
Configuration menu - View commit details
-
Copy full SHA for 2aa60ce - Browse repository at this point
Copy the full SHA 2aa60ceView commit details -
actions: add accessors to
UUID
andTime
properties for "action wr……apper types" This uses the base type `IMessage` to get around the cyclic references.
Configuration menu - View commit details
-
Copy full SHA for 37845b0 - Browse repository at this point
Copy the full SHA 37845b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab8aff4 - Browse repository at this point
Copy the full SHA ab8aff4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b85387 - Browse repository at this point
Copy the full SHA 0b85387View commit details -
Configuration menu - View commit details
-
Copy full SHA for eec1f7f - Browse repository at this point
Copy the full SHA eec1f7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71ad79b - Browse repository at this point
Copy the full SHA 71ad79bView commit details
Commits on Jun 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 83746eb - Browse repository at this point
Copy the full SHA 83746ebView commit details
Commits on Jun 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e1b38da - Browse repository at this point
Copy the full SHA e1b38daView commit details
Commits on Jul 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 41cf05b - Browse repository at this point
Copy the full SHA 41cf05bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdab894 - Browse repository at this point
Copy the full SHA fdab894View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b71121 - Browse repository at this point
Copy the full SHA 3b71121View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2e46d9 - Browse repository at this point
Copy the full SHA b2e46d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6639a6 - Browse repository at this point
Copy the full SHA e6639a6View commit details
Commits on Jul 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3ffbd2d - Browse repository at this point
Copy the full SHA 3ffbd2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04b2019 - Browse repository at this point
Copy the full SHA 04b2019View commit details -
actions: use return value from Interlocked.CompareExchange
The field access after Interlocked.CompareExchange might not reflect the updated value. Or does it? Anyways this makes it more clear.
Configuration menu - View commit details
-
Copy full SHA for 02cf5a5 - Browse repository at this point
Copy the full SHA 02cf5a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 459c229 - Browse repository at this point
Copy the full SHA 459c229View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15156b0 - Browse repository at this point
Copy the full SHA 15156b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 866834a - Browse repository at this point
Copy the full SHA 866834aView commit details
Commits on Aug 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5fda852 - Browse repository at this point
Copy the full SHA 5fda852View commit details
Commits on Sep 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0019358 - Browse repository at this point
Copy the full SHA 0019358View commit details
Commits on Oct 11, 2022
-
bool pInvoke: Fix bool pInvokes in generated messages
This does not change the C# side of the generated messages to avoid even more complexity in the templates. As bools in C# pInvokes get marshalled as 32 bit integer by default there is no strictly need to change the code for bool fields.
Configuration menu - View commit details
-
Copy full SHA for 275dc2b - Browse repository at this point
Copy the full SHA 275dc2bView commit details
Commits on Oct 13, 2022
-
Add quality of service for publishers and subscribers.
Most of the documentation was taken from ros2_rust. https://github.com/ros2-rust/ros2_rust/blob/main/rclrs/src/qos.rs
Configuration menu - View commit details
-
Copy full SHA for 2f857a3 - Browse repository at this point
Copy the full SHA 2f857a3View commit details
Commits on Nov 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bb16831 - Browse repository at this point
Copy the full SHA bb16831View commit details
Commits on Jun 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 328145e - Browse repository at this point
Copy the full SHA 328145eView commit details
Commits on Jun 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd7b86d - Browse repository at this point
Copy the full SHA fd7b86dView commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5788f59 - Browse repository at this point
Copy the full SHA 5788f59View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2b7553 - Browse repository at this point
Copy the full SHA d2b7553View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 58b970b - Browse repository at this point
Copy the full SHA 58b970bView commit details
Commits on Mar 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e328135 - Browse repository at this point
Copy the full SHA e328135View commit details
Commits on Nov 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 30bdf4f - Browse repository at this point
Copy the full SHA 30bdf4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08ec73a - Browse repository at this point
Copy the full SHA 08ec73aView commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for db91259 - Browse repository at this point
Copy the full SHA db91259View commit details