Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API for an RMW implementation to check if an event type is supported #394

Open
Yadunund opened this issue Mar 5, 2025 · 4 comments

Comments

@Yadunund
Copy link
Member

Yadunund commented Mar 5, 2025

An RMW implementation does not need to support all the event types in rmw_event_type_t. But there are several tests in our CI that validate whether the mechanism to handle events is supported. In such tests, we could either have the RMW return a list of events that it supports or rely on a new API to validate whether an event type is supported by the RMW before proceeding to test with the event type.

@Yadunund Yadunund changed the title Add an API for an RMW implementation to return a list of event types that i supports Add an API for an RMW implementation to return a list of event types that it supports Mar 5, 2025
@Yadunund Yadunund changed the title Add an API for an RMW implementation to return a list of event types that it supports Add an API for an RMW implementation to check if an event type is supported Mar 5, 2025
@ahcorde
Copy link
Contributor

ahcorde commented Mar 5, 2025

We already have zenoh_event_from_rmw_event() which I think this might be helpful, where you can ask if a event is supported by the rmw.

@ahcorde
Copy link
Contributor

ahcorde commented Mar 5, 2025

but this is not exposed in rmw_implementation. I will create something like rmw_supported_events()

@fujitatomoya
Copy link
Collaborator

this interface sounds reasonable.
we do not need it now but could be exposed to client layer so that we can call this when adding the event handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants