-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rmw_event_type_is_supported #173
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Pulls: ros2/rmw#395, ros2/rmw_implementation#250, ros2/rmw_cyclonedds#532, ros2/rmw_fastrtps#809, #173 |
@@ -64,6 +64,13 @@ rmw_api_connextdds_publisher_event_init( | |||
} | |||
|
|||
|
|||
bool | |||
rmw_event_type_is_supported(rmw_event_type_t rmw_event_type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep this consistent with how the code is structured, let's make a couple of changes:
- Call this function
rmw_api_connextdds_event_type_is_supported
. - Add its declaration in the header
rmw_connextdds_common/include/rnw_connextdds/rmw_api_impl.hpp
in the "Event API" section. - Use the implementation of
is_even_supported
and delete the function. - Add the function
rmw_event_type_is_supported
in bothrmw_api_impl_ndds.cpp
andrmw_api_impl_rtime.cpp
in the "Event API" section using the commonrmw_api_connextdds_event_type_is_supported
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahcorde I've added a couple of comments to keep the code consistent. Take a look at then whenever you can
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Related with this issue ros2/rmw#394. Check if a event is supported by the
rmw