Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rmw_event_type_is_supported #173

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
+28 −11
Open

Added rmw_event_type_is_supported #173

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1728ce8
Added rmw_event_check_compatible
ahcorde Mar 5, 2025
c1a4b47
review feedback
ahcorde Mar 6, 2025
1c1877b
Added review feedback
ahcorde Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rmw_connextdds_common/src/common/rmw_event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@ rmw_api_connextdds_publisher_event_init(
}


bool
rmw_event_type_is_supported(rmw_event_type_t rmw_event_type)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this consistent with how the code is structured, let's make a couple of changes:

  • Call this function rmw_api_connextdds_event_type_is_supported.
  • Add its declaration in the header rmw_connextdds_common/include/rnw_connextdds/rmw_api_impl.hpp in the "Event API" section.
  • Use the implementation of is_even_supported and delete the function.
  • Add the function rmw_event_type_is_supported in both rmw_api_impl_ndds.cpp and rmw_api_impl_rtime.cpp in the "Event API" section using the common rmw_api_connextdds_event_type_is_supported function.

{
return is_event_supported(rmw_event_type);
}


rmw_ret_t
rmw_api_connextdds_subscription_event_init(
rmw_event_t * rmw_event,
Expand Down