Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rmw_event_type_is_supported #809

Open
wants to merge 5 commits into
base: rolling
Choose a base branch
from
Open

Added rmw_event_type_is_supported #809

wants to merge 5 commits into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 5, 2025

Related with this issue ros2/rmw#394. Check if a event is supported by the rmw

@ahcorde
Added rmw_event_check_compatible
3e1ff3c 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Mar 5, 2025
@ahcorde ahcorde requested a review from Yadunund March 5, 2025 13:49
@ahcorde ahcorde mentioned this pull request Mar 5, 2025
Open
@ahcorde
Fixed build
e8c79a6 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
included review feedback
6249501 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
MiguelCompany
MiguelCompany requested changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not resist my OCD...

ahcorde and others added 2 commits March 6, 2025 10:20
@ahcorde
review feedback
037d718 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde @MiguelCompany
Update rmw_fastrtps_cpp/src/rmw_event.cpp
9465890 
Co-authored-by: Miguel Company <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde mentioned this pull request Mar 6, 2025
Open
@ahcorde
Copy link
Contributor Author

ahcorde commented Mar 6, 2025

Pulls: ros2/rmw#395, ros2/rmw_implementation#250, ros2/rmw_cyclonedds#532, #809, ros2/rmw_connextdds#173
Gist: https://gist.githubusercontent.com/ahcorde/f7979a231857cd476a5e7f5ecc5e96cc/raw/d7b1d7bff818a741abc52a4b3c4a30522a0d8002/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
TEST args: --packages-above rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15294

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Mar 6, 2025
Open
Open
Open
@MiguelCompany
Copy link
Collaborator

Pulls: ros2/rmw#395, ros2/rmw_implementation#250, ros2/rmw_cyclonedds#532, #809, ros2/rmw_connextdds#173 Gist: https://gist.githubusercontent.com/ahcorde/f7979a231857cd476a5e7f5ecc5e96cc/raw/d7b1d7bff818a741abc52a4b3c4a30522a0d8002/ros2.repos BUILD args: --packages-above-and-dependencies rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common TEST args: --packages-above rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15294

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

You need to run CI manually, since rmw_fastrtps_dynamic_cpp is ignored by default

@ahcorde ahcorde changed the title Added rmw_event_check_compatible Added rmw_event_type_is_supported Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany requested changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Awaiting requested review from Yadunund

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @MiguelCompany @fujitatomoya