Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enclave option functions. #393

Merged
merged 1 commit into from
Mar 5, 2025
Merged

add enclave option functions. #393

merged 1 commit into from
Mar 5, 2025

Conversation

fujitatomoya
Copy link
Collaborator

fujitatomoya
fujitatomoya commented Mar 1, 2025
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR adds the following, and rcl and rmw implementation depends on. the idea is to manage the rmw structure data in rmw layer just like other options. this is the root cause of micro-ROS/rmw_microxrcedds#311.

  • rmw_enclave_options_copy
  • rmw_enclave_options_fini

we do not need to rmw_enclave_options_init, because it is actrually char * and can be initialized with rmw_init_options_init.

This was referenced Mar 1, 2025
Merged
Merged
Merged
Merged
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Mar 3, 2025

Pulls: #393, ros2/rmw_implementation#247, ros2/rmw_fastrtps#808, ros2/rmw_cyclonedds#531, ros2/rmw_connextdds#172
Gist: https://gist.githubusercontent.com/ahcorde/b30e5b3b0088a19febb67126aa9ebf1b/raw/c55392e2440d76749d925032d10fb3474a9fec38/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common rmw_cyclonedds_cpp rmw rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp
TEST args: --packages-above rmw_connextdds_common rmw_cyclonedds_cpp rmw rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15263

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Mar 3, 2025

Pulls: #393, ros2/rmw_implementation#247, ros2/rmw_fastrtps#808, ros2/rmw_cyclonedds#531, ros2/rmw_connextdds#172
Gist: https://gist.githubusercontent.com/ahcorde/62a6bc3028e527e02a193cf03822ace3/raw/c55392e2440d76749d925032d10fb3474a9fec38/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common rmw_cyclonedds_cpp rmw rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_shared_cpp
TEST args: --packages-above rmw_connextdds_common rmw_cyclonedds_cpp rmw rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15266

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@ahcorde thanks for trying to start the CI. i think i need to rebase those, since they are missing latest your change that is security common interfaces. i will rebase them all and retry the CI.

@fujitatomoya
add enclave option functions.
7af633d 
Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/rmw_options_enclave branch from f923c40 to 7af633d Compare March 3, 2025 18:08
@fujitatomoya
Copy link
Collaborator Author

Pulls: #393, ros2/rmw_implementation#247, ros2/rmw_fastrtps#808, ros2/rmw_cyclonedds#531, ros2/rmw_connextdds#172
Gist: https://gist.githubusercontent.com/fujitatomoya/5bc0cd80ef00e7970eb0008e0272b00f/raw/c55392e2440d76749d925032d10fb3474a9fec38/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common rmw_cyclonedds_cpp rmw rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp
TEST args: --packages-above rmw_connextdds_common rmw_cyclonedds_cpp rmw rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15268

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

CI is failing because,

  • connextdds is not available for aarch64.
  • rmw_fastrtps_dynamic_cpp is not avaiable.

i will start the full CI instead.

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Mar 3, 2025 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

windows build warning is unrelated, https://ci.ros2.org/job/ci_windows/23426/#showFailuresLink

@fujitatomoya fujitatomoya merged commit abdbee5 into rolling Mar 5, 2025
3 checks passed
@fujitatomoya fujitatomoya mentioned this pull request Mar 5, 2025
Merged
@ahcorde ahcorde deleted the fujitatomoya/rmw_options_enclave branch March 6, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

introduce rmw_copy(fini)_options_enclave
2 participants
@fujitatomoya @ahcorde