Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Chrome no longer supports old headless mode #189

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: Chrome no longer supports old headless mode #189

merged 2 commits into from
Jan 16, 2025
+12 −12

Conversation

gadenbuie
Copy link
Member

Fixes #187

We now default to --headless and pass whatever value is given in chromote.headless or CHROMOTE_HEADLESS along directly to Chrome, relying on Chrome to fail for invalid headless values (if it fails at all).

@gadenbuie gadenbuie marked this pull request as ready for review January 16, 2025 20:46
@gadenbuie gadenbuie requested a review from cderv January 16, 2025 20:47
cderv
cderv approved these changes Jan 16, 2025
View reviewed changes
Copy link

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you know if new headless works well with chromote already ?

@gadenbuie gadenbuie mentioned this pull request Jan 16, 2025
Merged
@gadenbuie
Copy link
Member Author

Do you know if new headless works well with chromote already ?

In theory, it should! IIRC pagedown::chrome_print() uses --headless by default, and therefore the new headless mode, and that seems to be working okay for most users.

@gadenbuie gadenbuie merged commit 91aeeaa into main Jan 16, 2025
12 checks passed
@gadenbuie gadenbuie deleted the fix/187-old-headless-mode-is-gone branch January 16, 2025 21:42
@gadenbuie gadenbuie mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cderv cderv cderv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome v132 no longer supports old headless mode
2 participants
@gadenbuie @cderv