Changes Requested:Readme:correct test command #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from reservations controller
RileyManda
changed the title
RileyManda
requested review from
Yonashenok and
rubydevi
and removed request for
Yonashenok
rubydevi
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Status: Approved 🟢 🟢 🟢
Hi @RileyManda
Great job on implementing all the requested changes by the previous reviewer. You can merge it on dev. Congratulations! 🎉
Highlights:
✅ Correct Gitflow
✅ All Linters passed
✅ Model spec passed
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed the following changes requested 🌱
Implementations
Kanban Progress