Add support for symbols in js_name
and getter
/setter
#4230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4149.
This PR adds basic support for
js_name = Symbol.<name>
. It generally works, but still needs to be polished.TODO list:
this
#4225, Fixed generated types for getters and setters #4202, and Addnull
to argument types of optional parameters #4188. Those PR should be dealt with before this one.getter = name
doesn't rename imported static getters. Seeimport_static_symbol_getter
incrates/cli/tests/reference/symbol.rs
. This might be fixed by Fixed imports with late binding andthis
#4225.Symbol.dispose
as pointed out here.expose_symbol_dispose
method to do this.js_name = Symbol.name
in invalid positions. Users should ideally get an error from the#[wasm_bindgen]
macro, so users get errors in the IDEs.