-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding a new plate purpose for multiplexed sequencing submissions, to avoid FC #4550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-request-collection
…r-request-collection Y24-190-3: Support Limber with TransferRequestCollections
…cape into develop-Y24-190
This rule has been added to Rubocop's checks, then branched changes got merged in without this rule applied.
Also fix a similar issue in tube_creation
Fix Rubocop issues
and mark the more controversial ones as TODO
…be-from-tube-creation-endpoint Y24-190-3: Support Limber with TubeFromTubeCreation endpoint
i.e. they are all retrievable via a common transfers endpoint and you can filter by type if desired. No more individual endpoints for separate sub-class types.
…t-templates Y24-190: Create TagLayouts from TagLayoutTemplates in v2
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4550 +/- ##
===========================================
+ Coverage 89.18% 89.19% +0.01%
===========================================
Files 1392 1392
Lines 29830 29830
===========================================
+ Hits 26605 26608 +3
+ Misses 3225 3222 -3 ☔ View full report in Codecov by Sentry. |
docs: correct documentation link in yard badge
API v2 Milestone 3
dasunpubudumal
approved these changes
Dec 12, 2024
KatyTaylor
reviewed
Dec 12, 2024
…Y24-307-new-plate-purpose # Conflicts: # config/default_records/plate_purposes/005_limber_purposes.yml
closing this - as merging with develop went messy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.