Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a new plate purpose for multiplexed sequencing submissions, to avoid FC #4550

Closed
wants to merge 156 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
156 commits
Select commit Hold shift + click to select a range
a2ace43
Add a new API v2 resource for TransferRequestCollections
sdjmchattie Sep 23, 2024
0a1e8be
Add child as a non-settable relationship on PooledPlateCreationResource
sdjmchattie Sep 23, 2024
d9363b7
Add a test for a disallowed relationship
sdjmchattie Sep 24, 2024
2c23102
Add the controller and route for TransferRequestCollections
sdjmchattie Sep 25, 2024
3d8b60f
Add tests of the resource attributes on TransferRequestCollections
sdjmchattie Sep 25, 2024
6dd81ef
Add tests for requests to the transfer_request_collections endpoint
sdjmchattie Sep 26, 2024
30646fe
Rubocop
sdjmchattie Sep 26, 2024
60c8127
Use create_list in a factory instead of making my own array
sdjmchattie Sep 26, 2024
1b66f96
Fix comment on fetchable_fields
sdjmchattie Sep 26, 2024
121d211
Merge branch 'develop-Y24-190' into Y24-190-3-support-limber-transfer…
sdjmchattie Sep 26, 2024
09bf5e5
Merge pull request #4378 from sanger/Y24-190-3-support-limber-transfe…
sdjmchattie Oct 1, 2024
e302806
Merge branch 'develop-Y24-190' of https://github.com/sanger/sequences…
sdjmchattie Oct 1, 2024
da3c0c9
Prefer method calls with parentheses
sdjmchattie Oct 1, 2024
106cbcd
Shorten the example that exceeds 5 lines
sdjmchattie Oct 1, 2024
12d2e76
Add ignore rules for more extensive changes
sdjmchattie Oct 1, 2024
dbae5d1
Tidy up tube_from_tube_creation model
sdjmchattie Oct 1, 2024
166b7a5
Set up new endpoint for tube_from_tube_creation
sdjmchattie Oct 1, 2024
ac050f5
Merge pull request #4388 from sanger/fix-rubocop-issues
sdjmchattie Oct 1, 2024
ce2a12a
Add tests for TubeFromTubeCreation endpoint
sdjmchattie Oct 1, 2024
81bc2e4
Fix Rubocop concerns
sdjmchattie Oct 1, 2024
a9b181e
Make stub methods in abstract AssetCreation class
sdjmchattie Oct 16, 2024
f1dce8e
Address TODOs in documentation for TubeFromTubeCreationResource
sdjmchattie Oct 16, 2024
efeb113
Add missing comma in example
sdjmchattie Oct 16, 2024
c2ab3a6
Merge pull request #4390 from sanger/Y24-190-3-support-limber-with-tu…
sdjmchattie Oct 16, 2024
46b3976
Merge branch 'develop' into develop-Y24-190
sdjmchattie Oct 16, 2024
6b605c9
Fix pluralisation of tube_from_tube_creations endpoint in documentation
sdjmchattie Oct 17, 2024
57461b6
Tidy up BulkTransfer model
sdjmchattie Oct 17, 2024
390a90b
Implement the BulkTransfer resource and controller
sdjmchattie Oct 17, 2024
323a6b4
Use readonly, readwrite and new write_once options for resources
sdjmchattie Oct 17, 2024
067d552
Make Transfers behave like other sub-classed model types
sdjmchattie Oct 17, 2024
e86d56a
Rubocop and prettier
sdjmchattie Oct 17, 2024
8db4003
Fix pluralisation of tube_from_tube_creations endpoint in documentation
sdjmchattie Oct 17, 2024
b7ae240
Tidy up BulkTransfer model
sdjmchattie Oct 17, 2024
4f9f35a
Implement the BulkTransfer resource and controller
sdjmchattie Oct 17, 2024
a401ec9
Merge branch 'Y24-190-support-limber-with-bulk-transfers-on-v2-api' o…
sdjmchattie Oct 18, 2024
045c991
Use attribute options for BulkTransferResource
sdjmchattie Oct 18, 2024
af4a39b
Add test for BulkTransferResource
sdjmchattie Oct 18, 2024
74a4dd3
Apply additional tweaks using new permission model
sdjmchattie Oct 18, 2024
f153618
Add a BulkTransfer factory
sdjmchattie Oct 18, 2024
3b99e65
Make barcode printer name readonly
sdjmchattie Oct 18, 2024
a211847
Create tests for the bulk_transfer requests
sdjmchattie Oct 18, 2024
6dbedb7
Merge pull request #4426 from sanger/Y24-190-fix-api-v2-transfers
sdjmchattie Oct 18, 2024
3782fb4
Merge branch 'develop-Y24-190' into Y24-190-support-limber-with-bulk-…
sdjmchattie Oct 18, 2024
e78b99f
Apply Rubocop and linting rules
sdjmchattie Oct 18, 2024
8438179
Update devour rake task to only work on resources
sdjmchattie Oct 18, 2024
a2f2b33
Merge branch 'develop' into develop-Y24-190
sdjmchattie Oct 21, 2024
1bc21b7
Add endpoint resource for plate_conversions
sdjmchattie Oct 21, 2024
efcabcb
Add plate_conversions resource tests
sdjmchattie Oct 21, 2024
e3c2d13
Add tests for plate_conversion requests
sdjmchattie Oct 21, 2024
406931e
Ignore overly strict Rubocop rules
sdjmchattie Oct 21, 2024
ec83232
Merge branch 'develop' into develop-Y24-190
sdjmchattie Oct 21, 2024
6406814
Merge branch 'develop-Y24-190' into Y24-190-support-limber-with-plate…
sdjmchattie Oct 21, 2024
0556504
Merge branch 'develop-Y24-190' into Y24-190-support-limber-with-bulk-…
sdjmchattie Oct 21, 2024
0edfd55
Merge pull request #4436 from sanger/Y24-190-support-limber-with-plat…
sdjmchattie Oct 21, 2024
55df5ab
Add an endpoint for plate_creations
sdjmchattie Oct 21, 2024
5b22f24
Add tests for the PlateCreation resource
sdjmchattie Oct 21, 2024
b009516
Name shared examples correctly
sdjmchattie Oct 21, 2024
d1c211e
Extract the PlateCreation factory to its own file
sdjmchattie Oct 21, 2024
9e17755
Order relationships alphabetically
sdjmchattie Oct 21, 2024
1daad3b
Indicate why we define the barcode in the factory
sdjmchattie Oct 21, 2024
fc7b21f
Add tests for plate_creation requests
sdjmchattie Oct 21, 2024
50626e7
Split Matcher modules into Attributes and Relationships
sdjmchattie Oct 21, 2024
3b8a9ce
Check that child cannot be set as a relationship
sdjmchattie Oct 22, 2024
df9b383
Merge pull request #4425 from sanger/Y24-190-support-limber-with-bulk…
sdjmchattie Oct 23, 2024
f62293c
Merge branch 'develop' into develop-Y24-190
sdjmchattie Oct 23, 2024
12b5e97
Merge pull request #4439 from sanger/Y24-190-support-limber-with-plat…
sdjmchattie Oct 23, 2024
755e024
Merge branch 'develop' into develop-Y24-190
sdjmchattie Oct 23, 2024
6f64972
Fix references to requests test helper
sdjmchattie Oct 23, 2024
0953154
Merge branch 'develop' into develop-Y24-190
sdjmchattie Oct 24, 2024
e68aaa2
Fix naming of matcher for has_one instead of have_one
sdjmchattie Oct 25, 2024
06437d1
Update tests for about 1/3 of the V2 resources
sdjmchattie Oct 28, 2024
59ef913
Extract Receptacle shared examples
sdjmchattie Oct 28, 2024
47c957f
Update test syntax for four more endpoints
sdjmchattie Oct 28, 2024
8f7e573
Resolve Rubocop todos for NamedSubject among V2 Resources
sdjmchattie Oct 28, 2024
e7d82ba
Fix invalid factory for pooled_request
sdjmchattie Oct 28, 2024
3c9b0f6
Complete migration of resource tests to stricter relationship matchers
sdjmchattie Oct 28, 2024
7417377
Fix incorrect permissions for WorkOrder resource state attribute
sdjmchattie Oct 28, 2024
084a7d2
Fix transfer resource permissions
sdjmchattie Oct 28, 2024
445bc41
Clean up documentation on now-readable user_uuid attribute
sdjmchattie Oct 28, 2024
b30eb08
Merge branch 'develop' into develop-Y24-190
sdjmchattie Oct 29, 2024
1a322da
Merge pull request #4463 from sanger/Y24-190-use-stricter-rspec-teste…
sdjmchattie Oct 29, 2024
570d98a
Add sibling_tubes attribute to V2 tube
sdjmchattie Oct 29, 2024
4684569
Fix typo in comment
sdjmchattie Oct 31, 2024
23632f4
Update tests for tubes
sdjmchattie Oct 31, 2024
e166263
Fix typo in matcher name
sdjmchattie Oct 31, 2024
f4128f9
Merge branch 'develop' into develop-Y24-190
sdjmchattie Nov 4, 2024
009ec03
Merge branch 'develop-Y24-190' into Y24-190-support-limber-with-v2-tubes
sdjmchattie Nov 4, 2024
2a64fcd
Merge pull request #4474 from sanger/Y24-190-support-limber-with-v2-t…
sdjmchattie Nov 7, 2024
0c2522b
Use named column when grouping in SQL statement
sdjmchattie Nov 8, 2024
db696ea
Add submission_pools to v2 plates
sdjmchattie Nov 8, 2024
7d3a182
Make pooling metadata available for V2 Plate resources
sdjmchattie Nov 8, 2024
d674233
Merge branch 'develop' into develop-Y24-190
sdjmchattie Nov 8, 2024
9896eeb
Merge branch 'develop-Y24-190' of https://github.com/sanger/sequences…
sdjmchattie Nov 8, 2024
e8088a9
Start adding v2 QC Files to labware
sdjmchattie Nov 12, 2024
b060d59
Consider failed parses? method calls on Parsers as a no
sdjmchattie Nov 13, 2024
6cdf1be
Get QcFile resources working correctly during creation
sdjmchattie Nov 13, 2024
b163e85
Change asset relationship to labware
sdjmchattie Nov 13, 2024
f4416d5
Add transfers_as_destination to Plates v2 endpoint
sdjmchattie Nov 14, 2024
80954d5
Add created_at field to QcFile resources
sdjmchattie Nov 14, 2024
8c90700
Allow QcFile resources to be filtered by UUID
sdjmchattie Nov 14, 2024
ff958ee
Merge branch 'develop' into develop-Y24-190
sdjmchattie Nov 15, 2024
397ba03
Merge branch 'develop-Y24-190' into Y24-190-support-limber-with-v2-pl…
sdjmchattie Nov 15, 2024
aa69a27
Fix documentation of access levels for attributes
sdjmchattie Nov 15, 2024
35d7797
Document the PlateResource before writing tests
sdjmchattie Nov 15, 2024
8f6d84a
Update PlateResource tests
sdjmchattie Nov 18, 2024
349b977
Create QcFileResource tests
sdjmchattie Nov 18, 2024
2c852b4
Create tests for SubmissionPoolResource
sdjmchattie Nov 18, 2024
0ae6de8
Tidy up QcFileResource tests
sdjmchattie Nov 18, 2024
5d09962
Update tests for TransferResources
sdjmchattie Nov 18, 2024
c95d39b
Update documentation for LabwareResource and QcFileResource
sdjmchattie Nov 18, 2024
e539ed5
Fix an ordering issue with the declaration of submission_pools
sdjmchattie Nov 18, 2024
d43aba3
Update and enhance tests for PlateResource requests
sdjmchattie Nov 18, 2024
39bc91d
Prefer have_received over receive
sdjmchattie Nov 18, 2024
105bada
Fix some documentation boo-boos
sdjmchattie Nov 19, 2024
df7162b
Add QcFiles to the labware shared resource behaviour
sdjmchattie Nov 19, 2024
5166dfe
Make relationships tests less verbose
sdjmchattie Nov 19, 2024
80a8f27
Add tests for labware shared behaviour
sdjmchattie Nov 19, 2024
fa87150
Add tests for Parsers.parser_for method
sdjmchattie Nov 19, 2024
5130d19
Apply Rubocop fixes
sdjmchattie Nov 19, 2024
17a8859
Remove route for submission_pools
sdjmchattie Nov 19, 2024
443e480
Add tests for QC File requests
sdjmchattie Nov 19, 2024
fb7df99
Update tests for Transfers
sdjmchattie Nov 19, 2024
359018e
Add the route for submission_pools back in
sdjmchattie Nov 20, 2024
0733d86
Add tests for submission pool resources
sdjmchattie Nov 20, 2024
1a011e5
Don't overwrite a method parameter in the middle of the method
sdjmchattie Nov 21, 2024
2481fe2
Merge branch 'develop' into develop-Y24-190
sdjmchattie Nov 22, 2024
4c5e8c7
Merge branch 'develop-Y24-190' into Y24-190-support-limber-with-v2-pl…
sdjmchattie Nov 22, 2024
9878007
Merge pull request #4494 from sanger/Y24-190-support-limber-with-v2-p…
sdjmchattie Nov 22, 2024
6d56325
Switch Transfers to use a custom Processor
sdjmchattie Nov 22, 2024
e84301b
Make Transfer resources ignore the UUID from a template
sdjmchattie Nov 22, 2024
b87f15a
Handle missing template properly for Transfers
sdjmchattie Nov 22, 2024
de75009
Add logic for merging tag layout template data into a tag layout
sdjmchattie Nov 22, 2024
4e756e3
Prefer blocks over error arrays all over the place
sdjmchattie Nov 22, 2024
54eb01b
Fix copy-paste error in Rspec resource matchers
sdjmchattie Nov 25, 2024
8c52a14
Remove multiple expectations from test of TagLayout requests
sdjmchattie Nov 26, 2024
c198b1d
Add tests for TagLayoutTemplates provided for TagLayout creation
sdjmchattie Nov 26, 2024
881ae9c
Add enforce_uniqueness handling to tag_layout creation
sdjmchattie Nov 26, 2024
5943d9f
Update tests to expect template submissions to have been created
sdjmchattie Nov 27, 2024
253dec2
Do tests for enforce_uniqueness defaults and overrides
sdjmchattie Nov 27, 2024
473f672
Use value for setter parameters in YARD documentation
sdjmchattie Nov 27, 2024
5e316d2
Add tests for when the tag layout template uuid is invalid
sdjmchattie Nov 27, 2024
d328151
Merge branch 'develop' into develop-Y24-190
sdjmchattie Nov 27, 2024
ab257bc
Merge branch 'develop-Y24-190' into Y24-190-v2-create-from-tag-layout…
sdjmchattie Nov 27, 2024
4e769ef
Add missing model name test for QcFileResource
sdjmchattie Nov 28, 2024
c15f9f4
Use constant for BAD_REQUEST instead of 400
sdjmchattie Dec 2, 2024
64ba425
Merge pull request #4515 from sanger/Y24-190-v2-create-from-tag-layou…
sdjmchattie Dec 2, 2024
fd23f67
Merge branch 'develop' into develop-Y24-190
sdjmchattie Dec 2, 2024
25682a1
Merge branch 'develop' into api-v2-milestone-3
sdjmchattie Dec 10, 2024
61203c8
adding a new plate purpose for multiplexed sequencing submissions, to…
sabrine33 Dec 10, 2024
39a0f1d
docs: correct documentation link in yard badge
StephenHulme Dec 11, 2024
cb83d87
Merge pull request #4552 from sanger/sh51/docs-link
StephenHulme Dec 11, 2024
62da168
Merge pull request #4533 from sanger/api-v2-milestone-3
sdjmchattie Dec 11, 2024
51b38d0
Bump version to 14.52.0
sdjmchattie Dec 11, 2024
4520a63
adding a new plate purpose for multiplexed sequencing submissions, to…
sabrine33 Dec 10, 2024
e4b9e38
update comment accordingly to C.R
sabrine33 Dec 12, 2024
c8d93fd
Merge remote-tracking branch 'origin/Y24-307-new-plate-purpose' into …
sabrine33 Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tidy up BulkTransfer model
sdjmchattie committed Oct 17, 2024
commit 57461b699fd23f72a6deb5604868bfc07fb3a2ba
6 changes: 3 additions & 3 deletions app/models/bulk_transfer.rb
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
# of individual transfers. Designed for use via the API
#
# @example Example usage
# BultTransfer.create!({
# BulkTransfer.create!({
# well_transfers: [
# {
# source_uuid: source_plate1.uuid, source_location: 'A1',
@@ -39,6 +39,8 @@ class BulkTransfer < ApplicationRecord

attr_accessor :well_transfers

private

def build_transfers!
ActiveRecord::Base.transaction do
each_transfer do |source, destination, transfers|
@@ -52,7 +54,6 @@ def build_transfers!
end
end
end
private :build_transfers!

def each_transfer # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
well_transfers
@@ -70,5 +71,4 @@ def each_transfer # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
yield(source, destination, transfers)
end
end
private :each_transfer
end