x1139 update amplification operation #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khelwood
approved these changes
Jan 25, 2024
|
@sabrine33 This pr fails cypress tests every time they run. Can you take a look at it please? |
|
I will have a look, thanks |
|
@sabrine33 That might have helped, but it's still failing in |
|
@sabrine33 Thanks for fixing the tests. 👍 Can you fix the merge conflicts please? |
|
@khelwood, I'd rather wait until @seenanair fixes the storybook issue in the CI. |
@sabrine33 As we discussed over slack, I hope you are not waiting over this issue |
…te-amplification-op # Conflicts: # src/components/slotMeasurement/SlotMeasurements.tsx # src/components/visiumQC/Amplification.tsx # src/types/sdk.ts # tests/unit/components/visiumQC/amplification.spec.tsx
This reverts commit 5dc90c0.
khelwood
reviewed
Jan 29, 2024
cypress/e2e/pages/visiumQC.cy.ts
Outdated
| @@ -58,8 +58,10 @@ describe('Visium QC Page', () => { | |||
| }); | |||
| it('has all slots as passed', () => { | |||
| cy.findAllByTestId('passIcon').then(($passIcons) => { | |||
| debugger; | |||
There was a problem hiding this comment.
Please remember to remove this debugger when you're done with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.