Added the filtering of products based on category #42 Seperating products based on category. #178
Conversation
…eperating products based on category.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for scrollme-ecommerce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@thakuratul2 @saurabhbakolia Can you review and merge it soon its been so many days since it is open |
|
@saurabhbakolia merge this code i done with the review |
thakuratul2
added
gssoc-ext
|
@thakuratul2 @saurabhbakolia Still it is pending. Reminding you .... |
|
@tarunkumar2005 buddy please wait na |
I was told if the PR is not merged you need to remind the Project mentor and admin everyday so that they don't forget about it in lot of traffic that's why. @thakuratul2 |
|
@tarunkumar2005 i know buddy i already told to the project admin |
|
@thakuratul2 and @saurabhbakolia Can you please merge this if you are done with the review i think you are done with the review @thakuratul2 but i don't see @saurabhbakolia is giving any response to this didn't merged it since then if you have found any issue then you can tell me i will solve but no response and no action on the PR shouldn't be there. |
|
@saurabhbakolia and @thakuratul2 Pending PR (reminder) its been a week. |
|
@saurabhbakolia please review it |
|
@thakuratul2 Just asking can't i trigger this reivew
You have triggered just now |
|
@tarunkumar2005 i already message |
|
@thakuratul2 No bro i was asking like if i have access to trigger this review thing from a person like from admin or mentor but i think i don't have as a contributor. just asking that no worries i was just reminding you. Take it easy |
|
@tarunkumar2005 oky |
|
@saurabhbakolia Your mentor has told you so many times to respond, why are you not responding yet? I have also seen that you didn't added hacktoberfest topic in your PR yet, or at least allow atul to merge these PRs, @thakuratul2 I saw you are working really hard here, if you want to switch the project then let me know, I'll assign new one to you |
|
@thakuratul2 @saurabhbakolia What is this i didn't even made changes to these many files according to this PR why it is conflicting in these many files ??? may i know why it is happning. |
Hey @MastanSayyad, I had previously permitted @thakuratul2 before, but I’ve noticed too many bad merges. @MastanSayyad, How many mentors have you assigned for this project? |
Hey @tarunkumar2005, Also, please adjust your tone—everyone is doing their part. There's no need to keep reminding us, okay? |
I didn't said anything to you, i was just putting a reminder every two days as said by the sanjay sir and @MastanSayyad right keep reminding the PAs and mentors so that your message doesn't go unseen in much traffic that's why and about tone i have said nothing to you, then how you know what is my tone, you can check whole PR if i said anything to you which might have hurt your feelings or anything bad about you. and i was just asking why there are so many conflicting files is this bad tone? |
|
@saurabhbakolia Even when you are not actively viewing the PRs i didn't said anything i don't want to get involved in this i am just avoiding and thats why didn't raised any new issues if you are not actively particapiting then what will i do by raising issues it is just waste of time. So if you can merge this PR i will not raise new issues in your repo as i have seen how much you are actively contributing to the community and don't say these things when i have done nothing. |
|
@saurabhbakolia Check issue #191, I already contacted you several times, only 12 days has been left so it's crucial to merge all open PRs and assign all meaningful issues as well Those you think are bad PRs or issues just close them with proper closure, dont let contributors wonder why still PA has not responded, also are you active on discord? if yes please checkout the PA announcements. |
Thank you for informing me. I was a bit busy last week, but I have now added the relevant tags to the issues and PRs. I'll make sure to merge all open PRs and address any concerns promptly. I'll also check out the PA announcements on Discord. Thanks for your understanding! |
Hey @tarunkumar2005, I see that this PR has some meaningful code, but it won’t work as intended right now. Would you prefer I close it, or Will you wait for some days until I try to adjust the issue? Either option is fine with me. I’m currently working on refining the repository and improving the code styling to ensure that contributors don’t submit random code. I hope you understand. |
|
@saurabhbakolia You can do whatever you want i submitted it 10 days ago i think still it is same and that time also it was same, i don't want to mess around for just 10 points if you want the code merge it, don't want it close it do whatever its in your hand, i can't fix anything in this now if you want this merge it otherwise close it or discard it even though it is just of 10 points you made me worry about it for 10 days don't wanna work on this now anyhow so do whatever you feel right. |
|
don't ask me for any changes in this i am fond of this now. changing every 2nd day |
|
Hey @tarunkumar2005, Closing this PR, as this feature is not required for now! Thanks. |
No one the core team made this suggestion to remind them everyday by tagging. @tarunkumar2005 Everyone is doing their job and admin has mentioned you why there is delay. |
|
https://youtu.be/TIzrPn1AnYo?si=wG2e6h552JW3y5Tp I have already created to video on how to find active projects. https://github.com/apache/airflow look how many PR and issue and wait time on single PR. |
|
@sanjay-kv I don't have issue with the team or so i have issue with the project admins like this not replying for so long then saying it is not needed or it is done by someone else now but if you are saying that i don't need to mention them, remind them or just submit the PR and forget about it then its fine i can do that no worries, i am a bit impatient i think so sorry for that i will keep this in mind. and i saw this open source repo you mentioned, i understood now open source takes time and it can't be forced somehow so sorry for this. |
|
try to give some explanation in future why its not required or use automated bot for issue and PR. |
Pull Request Template
Added the filtering of products based on category #42 Seperating products based on category.
Description
I have properly done the seperation of products based on category and add filtering too so you can check it out and merge it.
Related Issue
#42 Seperating products based on category.
Changes Made
I have maded changes in ProductGallery.jsx and data.js in productGallery i have added filter and functioning of seperating and in data.js added the category to each of the product and also created a new list of categories used to create the filter.
Checklist
Screenshots (if applicable)
@thakuratul2 @saurabhbakolia Check this PR and merge it then assign this to me and put relvent labels like gssoc 2024 ext and hacktoberfest and level.