Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppressions #202

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Add suppressions #202

merged 4 commits into from
Oct 17, 2024

Conversation

henrikth93
Copy link
Member

This commit will add suppressions for "Long method"

Contributor checklist


Description

Related issue

Copy link

github-actions bot commented Oct 15, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 15, 2024
@andrewtavis
Copy link
Member

@angrezichatterbox, are you good with the suppressions here, or should any of these be broken up?

@angrezichatterbox
Copy link
Member

@angrezichatterbox, are you good with the suppressions here, or should any of these be broken up?

I suggested using Suppress for now as some of the classes would be modified or deleted. @henrikth93 Apologies for earlier stating that MyKeyboardView has to be suppressed for handling LongMethod. We could refractor a few of its functions but we would have to consider a throughout check of whether the keyboard is being drawn properly. Other classes for now I think its fine to have them suppressed as it would be removed later on.

@andrewtavis
Copy link
Member

Now I'm just confused 😅 Sorry, so we need to be explicit to say that we want tests to run? And the test was passing, then I removed the true entries because I thought it would default to being ran, and then the test failed, and now I've added them back in and it fails still?

@angrezichatterbox
Copy link
Member

Now I'm just confused 😅 Sorry, so we need to be explicit to say that we want tests to run? And the test was passing, then I removed the true entries because I thought it would default to being ran, and then the test failed, and now I've added them back in and it fails still?

We have to rebase the branch with the main and then fix the remaining linting issues. This would fix the problem. I had a similar issue with my PR where I was shown a linting issue in a line that was not present in my branch.

@henrikth93
Copy link
Member Author

Now I'm just confused 😅 Sorry, so we need to be explicit to say that we want tests to run? And the test was passing, then I removed the true entries because I thought it would default to being ran, and then the test failed, and now I've added them back in and it fails still?

We have to rebase the branch with the main and then fix the remaining linting issues. This would fix the problem. I had a similar issue with my PR where I was shown a linting issue in a line that was not present in my branch.

Alright!

henrikth93 and others added 4 commits October 17, 2024 20:36
This commit will add suppressions for "Long method"
This commit will add a suppress for long methods in LanguageSettingsFragment.kt
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful stuff, @henrikth93! 🚀 Thanks for the quick fix here and cleaning my mess :)

@andrewtavis andrewtavis merged commit 43ec2d7 into scribe-org:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants