Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french translation #19

Merged
merged 5 commits into from
Jan 5, 2018
Merged

Add french translation #19

merged 5 commits into from
Jan 5, 2018

Conversation

hugosaintemarie
Copy link
Contributor

Hi! I think your tools for arrays and objects exploring are very useful and just thought I'd give a hand for this french translation. Let's discuss it here!

@sdras
Copy link
Owner

sdras commented Jan 3, 2018

Hi @Ashugeo, thanks for your help! There are actually a few more things that need to be done to create a full translation. Can you please head over to CONTRIBUTING.md, there's a section on Translations there :) Thanks!

@sdras
Copy link
Owner

sdras commented Jan 3, 2018

@mmnlfrrr had expressed interest in creating a French translation in #1, perhaps you two can collaborate?

@hugosaintemarie
Copy link
Contributor Author

Yeah I just saw #1, sorry, should have looked up there first! @mmnlfrrr feel free to ping me if you started translating in french as well. 🙂

Also I'm working on the files in /store right now.

@hugosaintemarie
Copy link
Contributor Author

@sdras I'm done. Maybe @mmnlfrrr would you like to review my translation and credit yourself when it's done? I may have left some typos, and I guess some sentences can be improved.

@sdras
Copy link
Owner

sdras commented Jan 3, 2018

I love that, I'll leave it open for a day and then just merge it in if we haven't heard back. THANK YOU!

@mmnlfrrr
Copy link

mmnlfrrr commented Jan 4, 2018

@Ashugeo was faster than me. I will do a relecture to see if there are errors

@sdras sdras merged commit 285167e into sdras:master Jan 5, 2018
@sdras
Copy link
Owner

sdras commented Jan 5, 2018

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants