Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move interactive API examples to openfl-contrib #9

Conversation

vrancurel
Copy link

As we deprecate the interactive API by a more generalized form with the workflow API, we
decided to keep the examples in this repo.

@vrancurel vrancurel force-pushed the move_interactive_api_examples_to_contrib branch from 42e53c3 to 8319f09 Compare November 6, 2024 23:39
    As we deprecate the interactive API by a more generalized form with the workflow API, we
    decided to keep the examples in this repo.

Signed-off-by: Rancurel, Vianney <[email protected]>
@vrancurel vrancurel force-pushed the move_interactive_api_examples_to_contrib branch from 8319f09 to 642aedc Compare November 6, 2024 23:42
@teoparvanov
Copy link
Contributor

teoparvanov commented Nov 7, 2024

Thanks, @vrancurel for moving the Interactive API examples out of OpenFL, as we are deprecating Interactive API in 1.7!

@kta-intel, please note this is just a suggested temporary situation for OpenFL 1.7 where the Interactive API is marked as deprecated, but not removed from the OpenFL codebase. Assuming we take this next step in 1.8, we can remove all Interactive API examples from here too.

PS: in the meantime, a selection of these examples can be migrated to Workflow API in 1.7

@kta-intel
Copy link
Collaborator

Thanks @vrancurel and @teoparvanov

Couple questions/comments:

  1. have these examples been tested and found to at least be functional?
  2. is there a reason why we have decided not to remove them outright from v1.7? Considering that they are archived in previous versions (i.e. openfl/tree/v1.6) it might be safe to just remove them or move them to a subfolder labeled deprecated rather than move them here

@teoparvanov
Copy link
Contributor

teoparvanov commented Nov 8, 2024

Hi @kta-intel, as you can see in securefederatedai/openfl#1125, the suggestion is to remove those example from the OpenFL repo. Now, the question is whether to archive them or "store" them temporarily in openfl-contrib.

In any case, I don't think it's a good investment to spend time fixing them. The only reason to keep them around for a bit is if someone would like to experiment with Director/Envoy while the FederatedRuntime for Workflow API is still under development,

@teoparvanov
Copy link
Contributor

@vrancurel the suggestion is to close this PR, as per our offline discussion with @kta-intel on the plan for deprecating Interactive API.

@vrancurel
Copy link
Author

Decision to keep the examples into the main repo under a "deprecated" folder, so closing this PR without merging.

@vrancurel vrancurel closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants