Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate interactive API #1125

Merged
merged 1 commit into from
Nov 14, 2024
Merged

deprecate interactive API #1125

merged 1 commit into from
Nov 14, 2024

Conversation

vrancurel
Copy link
Contributor

@vrancurel vrancurel commented Nov 6, 2024 •
edited by teoparvanov
Loading

  • Move the interactive_api examples under openfl-tutorials/deprecated
  • Mark interactive_api as deprecated in the doc
  • Remove interactive_api from CI/CD

teoparvanov
teoparvanov reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@teoparvanov teoparvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at first glance. Here are a couple of things I noticed:

openfl-tutorials/Federated_Pytorch_MNIST_Tutorial.ipynb Outdated Show resolved Hide resolved
.github/workflows/ubuntu.yml Show resolved Hide resolved
kta-intel
kta-intel reviewed Nov 7, 2024
View reviewed changes
docs/about/releases.md Outdated Show resolved Hide resolved
@kta-intel
Copy link
Collaborator

Thanks @vrancurel, this is definitely a much needed PR! However, I'd just like some clarity on the plan

@teoparvanov teoparvanov mentioned this pull request Nov 8, 2024
Closed
@vrancurel vrancurel force-pushed the deprecate_interactive_api branch 2 times, most recently from 8b06d64 to 76e224a Compare November 12, 2024 21:29
@tanwarsh tanwarsh mentioned this pull request Nov 13, 2024
Open
@vrancurel
deprecate interactive API
547d496 
- Point interactive_api examples to openfl-contrib (where they have been moved)
- Mark interactive_api as deprecated in the doc
- Remove interactive_api from CI/CD

Signed-off-by: Rancurel, Vianney <[email protected]>
@vrancurel
Copy link
Contributor Author

Thanks @tanwarsh please merge as needed.

@teoparvanov
Copy link
Collaborator

teoparvanov commented Nov 14, 2024 •
edited
Loading

Hi @vrancurel , do you intend to refactor kvasir-interactive to Workflow API in this PR, or in a separate one?
If done separately, then this PR could be merged as-is. So, please let me know what your plan is.

@vrancurel
Copy link
Contributor Author

In a separate one, please merge @teoparvanov

@teoparvanov teoparvanov merged commit 63177f4 into securefederatedai:develop Nov 14, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanwarsh tanwarsh tanwarsh approved these changes

@kta-intel kta-intel kta-intel approved these changes

@MasterSkepticista MasterSkepticista MasterSkepticista approved these changes

@teoparvanov teoparvanov teoparvanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vrancurel @kta-intel @teoparvanov @MasterSkepticista @tanwarsh