Cosmos gas multiplier params #1546

Kbhat1 · 2024-04-16T02:00:16Z

Describe your changes and provide context

Add Cosmos gas multiplier numerator and denominator as param instead of hardcoded
Removes wasm dependency discount
Relies on sei-cosmos PR: Cosmos gas multiplier params sei-cosmos#487
Relies on sei-wasmd PR: Update LimitSimulationGasDecorator with custom Gas Meter Setter sei-wasmd#45

Testing performed to validate your change

Tested on local chain and verified multiplier

[EVM] add endpoint to get block transaction count

* [EVM] add get transaction receipt endpoint * refactor tests

[EVM] add getTransaction endpoints

[EVM] refactor gas logic

* [EVM] add endpoint to return fee history * bump to 1.21

* Implement get code, storage, balance endpoints * revert logging change * also using bank keeper to check for balances * appease linter

* simulate api * add tests * linter

* [EVM] add subscription utility * finished new filter * finished tests for new filter * finished uninstall filter * query tendermint for events * in progress * got first couple of tests done * finished tests for get logs * get filter logs and get filter changes * refactor * get filter logs accepts multiple addresses * use multiple addresses and use cursor map * remove bad test * remove prints and todos * minor fix * fix lint errors and failing test * poc to pass filtercriteria into JSON RPC * made topics 2d array and adjusted regex * GetLogs tests work * Finished other functions * remove unncessary inputs from NewFilterAPI * add expiration/timeouts for filters * removed error from UninstallFilter * minor fix * appease linter --------- Co-authored-by: codchen <[email protected]>

* [EVM] return gas info in message handler correctly * add comments

* integration * fix tests

* [EVM] add transaction type to associate account * tests

* [EVM] add transaction type to associate account * [EVM] convert balance decimal points * [EVM] add ACL dependencies for EVM transactions * Revert "[EVM] add ACL dependencies for EVM transactions" This reverts commit 5376a87. * address comments

* added new block filter * wip * finished tests * minor fix * fix lint * minor fix * fix test

* [EVM] surface VM error * rebase * add endpoints

* [EVM] several bug fixes * tests * add CheckTx nonce handling

* [EVM] several bug fixes * [EVM] add wasmd precompiles * [EVM] wasmd precompile * query method * add tests

* added new block filter * wip * finished tests * minor fix * fix lint * minor fix * added basic endpoint and created sendWSRequestAndListen * no goroutine in test * removed params * able to call my subscribe endpoint * subscribe2 works but not subscribe * got back msg from ws but hard to decode * subscription api uses sub manager, manager thread safe * able to send many messages through ws conn * newHeads tests work * newHeads works * subscribe works need to cleanup * test with multiple addrs, remove prints * cleanup * cleanup * fix test * fix linter * fix linter 2 * fix linter 3 * address comments * add unsubscribe in mock client * fix linter 4 * fix extra subscribe param * fix test

* [EVM] handle nonce gap in CheckTx * disable compatibility check

* chore: forge init * forge install: forge-std v1.7.2 * moved foundry.toml and github workflows to top level * forge install: openzeppelin-contracts v5.0.0 * added impl + tests for native sei tokens as erc20s * fix * fix * remove Counter boilerplate code * minor fix

…1159) * able to txn deployment to go through * cleanup * remove prints * remove prints * fix linter * minor fix

update tendermint version

* Add wasmd execute batch to precompile * Add some wasm hardhat it stuff * update script * Update deployment script * fix tests * update to add instantiate

Kbhat1 · 2024-04-16T21:03:23Z

app/antedecorators/depdecorators/gas.go

@@ -10,6 +10,7 @@ type GasMeterSetterDecorator struct {
 }

 func (d GasMeterSetterDecorator) AnteDeps(txDeps []sdkacltypes.AccessOperation, tx sdk.Tx, txIndex int, next sdk.AnteDepGenerator) (newTxDeps []sdkacltypes.AccessOperation, err error) {
+	// TODO: Remove below since no more wasm dependency discount


Verifying in local chain / tests and then will remove this since we have no more wasm dependency discount

Kbhat1 · 2024-04-16T21:04:12Z

go.mod

@@ -344,7 +344,7 @@ require (
 )

 replace (
-	github.com/CosmWasm/wasmd => github.com/sei-protocol/sei-wasmd v0.1.0
+	github.com/CosmWasm/wasmd => github.com/sei-protocol/sei-wasmd v0.0.10-0.20240415230844-461d7d3b8890 // TODO: Update once sei-wasmd PR merged


This will be updated once sei-wasmd new tag is published

Kbhat1 · 2024-04-16T21:04:20Z

go.mod

@@ -354,7 +354,7 @@ replace (
 	github.com/sei-protocol/sei-db => github.com/sei-protocol/sei-db v0.0.35
 	// Latest goleveldb is broken, we have to stick to this version
 	github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7
-	github.com/tendermint/tendermint => github.com/sei-protocol/sei-tendermint v0.2.41-seiv2
+	github.com/tendermint/tendermint => github.com/sei-protocol/sei-tendermint v0.2.41-seiv2.0.20240416201336-c52dc88f0dd3 // TODO: Update once sei-tendermint PR merged


This will be updated once sei-tendermint new tag is published

codchen · 2024-04-17T02:29:24Z

app/app.go

-				MaxGas:   endBlockResp.ConsensusParamUpdates.Block.MaxGas,
+				MaxBytes:                       endBlockResp.ConsensusParamUpdates.Block.MaxBytes,
+				MaxGas:                         endBlockResp.ConsensusParamUpdates.Block.MaxGas,
+				CosmosGasMultiplierNumerator:   endBlockResp.ConsensusParamUpdates.Block.CosmosGasMultiplierNumerator,


do we need migration for new consensus params?

@codchen we removed this in favor of just adding in a new param in cosmos layer: sei-protocol/sei-cosmos#487

codecov-commenter · 2024-04-17T14:21:32Z

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 60.99%. Comparing base (7470aae) to head (4afbda8).
Report is 10 commits behind head on seiv2.

❗ Current head 4afbda8 differs from pull request most recent head 0a82d4d. Consider uploading reports for the commit 0a82d4d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            seiv2    #1546      +/-   ##
==========================================
+ Coverage   60.73%   60.99%   +0.25%     
==========================================
  Files         366      366              
  Lines       26047    26048       +1     
==========================================
+ Hits        15819    15887      +68     
+ Misses       9228     9152      -76     
- Partials     1000     1009       +9

Files	Coverage Δ
app/antedecorators/gas.go	`62.50% <75.00%> (-11.97%)`	⬇️
app/ante.go	`54.11% <40.00%> (-1.98%)`	⬇️

... and 18 files with indirect coverage changes

Kbhat1 · 2024-04-17T14:22:02Z

go.mod

 	github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v0.8.0
-	github.com/cosmos/cosmos-sdk => github.com/sei-protocol/sei-cosmos v0.2.80-seiv2
+	github.com/cosmos/cosmos-sdk => github.com/sei-protocol/sei-cosmos v0.2.81-seiv2.0.20240417141123-88fd96d3e0b4 // TODO: Update once sei-cosmos PR merged


This will be updated once sei-cosmos new tag is published

udpatil · 2024-04-17T17:37:21Z

app/antedecorators/gas.go

 	return func(simulate bool, ctx sdk.Context, gasLimit uint64, tx sdk.Tx) sdk.Context {
-		if simulate || ctx.BlockHeight() == 0 {
+		if ctx.BlockHeight() == 0 {


why don't we have simulate specific gas meter behavior? - we should still have some infinite gas meter that then applies the scaling factor to be able to accurate simulate, right?

we should be careful here given that the cachekv is no longer emitting events, and this is a difference in how the store accesses happen

I think for the purposes of this change, just to be safe, we should reintroduce the event emissions in cachekv (despite performance consequences) to ensure the parallel dag resource accesses remain accurate. This will need to be updated in sei-cosmos and then reflected here

@udpatil for first comment, new infinite multiplier gas meter has been added for simulation

codchen and others added 30 commits March 26, 2024 14:16

[EVM] add endpoints to get block transaction count (#1099)

8c02c0c

[EVM] add endpoint to get block transaction count

[EVM] add getTransactionReceipt (#1100)

6f9da33

* [EVM] add get transaction receipt endpoint * refactor tests

[EVM] add getTransactions endpoints (#1101)

5c7861e

[EVM] add getTransaction endpoints

[EVM] add endpoint to get transaction count by address (#1103)

e0b570a

[EVM] fix gas logic (#1104)

5888b96

[EVM] refactor gas logic

[EVM] add endpoint to return fee history (#1106)

a76232b

* [EVM] add endpoint to return fee history * bump to 1.21

[EVM] add info endpoints (#1107)

8f6740c

[EVM] eth state endpoints (#1105)

daa89d4

* Implement get code, storage, balance endpoints * revert logging change * also using bank keeper to check for balances * appease linter

[EVM] add subscription utility (#1109)

b63ac6d

[EVM] add endpoint to send transaction (#1108)

41dfe2f

[EVM] get simulation endpoints (#1110)

9653567

* simulate api * add tests * linter

[EVM] add getProof endpoint (#1114)

e92bd2e

[EVM] return gas info in message handler correctly (#1115)

74df7ef

* [EVM] return gas info in message handler correctly * add comments

EVM Module Integration (#1122)

9e555c0

* integration * fix tests

[EVM] add transaction type to associate account (#1126)

ed4f413

* [EVM] add transaction type to associate account * tests

[EVM] ETH block filter endpoint (#1127)

024b551

* added new block filter * wip * finished tests * minor fix * fix lint * minor fix * fix test

[EVM] surface VM error (#1130)

00eef06

* [EVM] surface VM error * rebase * add endpoints

[EVM] add ACL dependencies (#1129)

2b768c9

[EVM] several bug fixes (#1136)

e72c621

* [EVM] several bug fixes * tests * add CheckTx nonce handling

[EVM] add wasmd precompile (#1139)

f46b616

* [EVM] several bug fixes * [EVM] add wasmd precompiles * [EVM] wasmd precompile * query method * add tests

[EVM] add bank metadata precompile functions (#1140)

dc2a650

[EVM] handle gapped nonce in CheckTx (#1142)

98047a9

* [EVM] handle nonce gap in CheckTx * disable compatibility check

[EVM] fix getProof (#1145)

8d4af80

[EVM] add deps for EVM ante handlers (#1149)

42faea8

[EVM] denormalize intermediary and coinbase accounts (#1153)

2523083

[EVM] seid command to deploy erc20 contract for a native sei token (#…

742b72b

…1159) * able to txn deployment to go through * cleanup * remove prints * remove prints * fix linter * minor fix

stevenlanders and others added 3 commits April 15, 2024 14:46

[EVM] update sei-tendermint v0.2.41-seiv2 (#1544)

5caa031

update tendermint version

Add wasmd execute batch to precompile (#1529)

7470aae

* Add wasmd execute batch to precompile * Add some wasm hardhat it stuff * update script * Update deployment script * fix tests * update to add instantiate

Cosmos Gas Multiplier Params

0693fff

This was referenced Apr 16, 2024

Update LimitSimulationGasDecorator with custom Gas Meter Setter sei-protocol/sei-wasmd#45

Merged

Cosmos Gas Multiplier Param sei-protocol/sei-tendermint#227

Closed

Kbhat1 added the app-hash-breaking label Apr 16, 2024

Kbhat1 changed the base branch from main to seiv2 April 16, 2024 02:01

Kbhat1 added 2 commits April 15, 2024 22:04

Add comments

bb1b958

Update unit tests

4e5a009

Kbhat1 requested review from codchen and philipsu522 April 16, 2024 21:02

Kbhat1 commented Apr 16, 2024

View reviewed changes

Update tests

4da62e4

codchen approved these changes Apr 17, 2024

View reviewed changes

Update sei-cosmos

757db6d

This was referenced Apr 17, 2024

Cosmos gas multiplier param sei-protocol/sei-cosmos#486

Closed

Cosmos gas multiplier params sei-protocol/sei-cosmos#487

Closed

Kbhat1 commented Apr 17, 2024

View reviewed changes

bump sei-cosmos

2c6e284

philipsu522 approved these changes Apr 17, 2024

View reviewed changes

Update sei-cosmos

4afbda8

udpatil requested changes Apr 17, 2024

View reviewed changes

Kbhat1 added 2 commits April 17, 2024 14:52

Infinite Multiplier Gas Meter for simulation

d4f67e9

Add dep test

0a82d4d

udpatil force-pushed the seiv2 branch from 9403876 to df899bb Compare April 18, 2024 14:05

Kbhat1 closed this Apr 18, 2024

Kbhat1 mentioned this pull request Apr 18, 2024

Cosmos Gas Multiplier Params #1565

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cosmos gas multiplier params #1546

Cosmos gas multiplier params #1546

Kbhat1 commented Apr 16, 2024 •

edited

Loading

Kbhat1 Apr 16, 2024 •

edited

Loading

Kbhat1 Apr 16, 2024

Kbhat1 Apr 16, 2024

codchen Apr 17, 2024

Kbhat1 Apr 17, 2024

codecov-commenter commented Apr 17, 2024 •

edited

Loading

Kbhat1 Apr 17, 2024

udpatil Apr 17, 2024

udpatil Apr 17, 2024

udpatil Apr 17, 2024

Kbhat1 Apr 17, 2024

Cosmos gas multiplier params #1546

Cosmos gas multiplier params #1546

Conversation

Kbhat1 commented Apr 16, 2024 • edited Loading

Describe your changes and provide context

Testing performed to validate your change

Kbhat1 Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 17, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kbhat1 commented Apr 16, 2024 •

edited

Loading

Kbhat1 Apr 16, 2024 •

edited

Loading

codecov-commenter commented Apr 17, 2024 •

edited

Loading