Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos gas multiplier params #487

Closed
wants to merge 13 commits into from
Closed

Cosmos gas multiplier params #487

wants to merge 13 commits into from

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Apr 17, 2024

Describe your changes and provide context

Testing performed to validate your change

  • Sei-chain + verified on local chain

@Kbhat1 Kbhat1 changed the base branch from main to seiv2 April 17, 2024 14:15
@Kbhat1 Kbhat1 requested review from codchen and philipsu522 April 17, 2024 14:19
x/params/module.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 44.04762% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 55.34%. Comparing base (6f71ccb) to head (060b94d).

❗ Current head 060b94d differs from pull request most recent head d2fa137. Consider uploading reports for the commit d2fa137 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2     #487      +/-   ##
==========================================
- Coverage   55.35%   55.34%   -0.02%     
==========================================
  Files         629      630       +1     
  Lines       53964    54046      +82     
==========================================
+ Hits        29873    29912      +39     
- Misses      21957    22000      +43     
  Partials     2134     2134              
Files Coverage Δ
x/params/keeper/migrations.go 100.00% <100.00%> (ø)
x/params/module.go 57.14% <100.00%> (+1.82%) ⬆️
x/params/keeper/keeper.go 60.00% <88.88%> (+11.06%) ⬆️
x/params/types/genesis.go 0.00% <0.00%> (ø)
x/params/types/params.go 26.08% <52.17%> (+26.08%) ⬆️
x/params/client/cli/query.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@Kbhat1 Kbhat1 requested review from udpatil and codchen April 17, 2024 15:11
x/params/types/params.go Outdated Show resolved Hide resolved
Copy link
Contributor

@philipsu522 philipsu522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding migration logic - one thing i'd test locally too is migrating to a version with this change and verifying we have cosmosparams going fwd

@Kbhat1 Kbhat1 closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants