-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider): add SQLite sink support #124
Conversation
@techgarage-ir Thanks for the PR. We will review it soon. |
thanks a lot, really appreciate it!! I'll try do understand how to make tests work with the TestContainer package, I'd prefer it as it would give us a better integration suite. Just to let you know, I'll check the PR after we complete v3 development - this will require a small update to your implementation to align to the modified API. Just to know, do you prefer
Thanks a bunch 🥇 |
Hi again So good, I'm looking for v3. That's not matter, do what's your usual in project and I'll make required changes asap. |
as an update, I started working on a branch towards yours, to align with v3 and fix anything I find 😄 |
That's great, I've used v2 with Sqlite on a project and found just one bug that's log time is in incorrect timezone, but I guess that's being fixed in v3 due to this note. |
@techgarage-ir could you please update |
FYI: test update WIP. |
Yes, I'll check it ASAP. |
Hi @techgarage-ir , Fyi, I already pushed the updated code to your repo and was working on fixing tests. |
That's fine, I'm looking at it and will use it on some test projects to get more details. |
That's awesome, thanks! I'll try to complete the tests this weekend and notifiy you for a final greenlight 👍 |
code updated to final version, I fixed issues with the Datetime querying (since field is a text, it wasn't working correctly), feel free to give it a try - if you're okay with it, we can close the PR! @mo-esmp |
Thanks for the contribution, @techgarage-ir. |
Hi @followynne
I've made Sqlite support, some tests are failing because no TestContainers found for Sqlite so changed tests to use InMemory database instead but base classes use TestContainer.
Please take a look on it.