Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add SQLite sink support #124

Merged
merged 16 commits into from
Oct 6, 2024

Conversation

techgarage-ir
Copy link
Contributor

Hi @followynne
I've made Sqlite support, some tests are failing because no TestContainers found for Sqlite so changed tests to use InMemory database instead but base classes use TestContainer.
Please take a look on it.

@mo-esmp mo-esmp requested a review from followynne July 31, 2024 07:50
@mo-esmp
Copy link
Member

mo-esmp commented Jul 31, 2024

@techgarage-ir Thanks for the PR. We will review it soon.

@followynne
Copy link
Member

followynne commented Jul 31, 2024

Hi @techgarage-ir

thanks a lot, really appreciate it!!

I'll try do understand how to make tests work with the TestContainer package, I'd prefer it as it would give us a better integration suite.

Just to let you know, I'll check the PR after we complete v3 development - this will require a small update to your implementation to align to the modified API.

Just to know, do you prefer

  • I comment on this PR about required changes or
  • I create a branch with the changes and open a PR towards your personal branch?

Thanks a bunch 🥇

@followynne followynne self-assigned this Jul 31, 2024
@followynne followynne added .NET Pull requests that update .net code v3 enhancement New feature or request labels Jul 31, 2024
@techgarage-ir
Copy link
Contributor Author

Hi again

So good, I'm looking for v3.

That's not matter, do what's your usual in project and I'll make required changes asap.

@followynne
Copy link
Member

@techgarage-ir

as an update, I started working on a branch towards yours, to align with v3 and fix anything I find 😄

@techgarage-ir
Copy link
Contributor Author

That's great, I've used v2 with Sqlite on a project and found just one bug that's log time is in incorrect timezone, but I guess that's being fixed in v3 due to this note.

@mo-esmp
Copy link
Member

mo-esmp commented Oct 3, 2024

@techgarage-ir could you please update SqliteDataProvider based on the latest changes?
Please check SqlServerDataProvider.cs and SqlServerQueryBuilder.cs classes and update your PR accordingly.

@followynne
Copy link
Member

FYI: test update WIP.

@techgarage-ir
Copy link
Contributor Author

@techgarage-ir could you please update SqliteDataProvider based on the latest changes? Please check SqlServerDataProvider.cs and SqlServerQueryBuilder.cs classes and update your PR accordingly.

Yes, I'll check it ASAP.

@followynne
Copy link
Member

@techgarage-ir could you please update SqliteDataProvider based on the latest changes? Please check SqlServerDataProvider.cs and SqlServerQueryBuilder.cs classes and update your PR accordingly.

Yes, I'll check it ASAP.

Hi @techgarage-ir ,

Fyi, I already pushed the updated code to your repo and was working on fixing tests.
Please give it a look and a test if you have time,especially for the new sort feature, thanks!

@techgarage-ir
Copy link
Contributor Author

@techgarage-ir could you please update SqliteDataProvider based on the latest changes? Please check SqlServerDataProvider.cs and SqlServerQueryBuilder.cs classes and update your PR accordingly.

Yes, I'll check it ASAP.

Hi @techgarage-ir ,

Fyi, I already pushed the updated code to your repo and was working on fixing tests. Please give it a look and a test if you have time,especially for the new sort feature, thanks!
Hi

That's fine, I'm looking at it and will use it on some test projects to get more details.

@followynne
Copy link
Member

That's awesome, thanks! I'll try to complete the tests this weekend and notifiy you for a final greenlight 👍

@followynne
Copy link
Member

Hi @techgarage-ir

code updated to final version, I fixed issues with the Datetime querying (since field is a text, it wasn't working correctly), feel free to give it a try - if you're okay with it, we can close the PR!

@mo-esmp
I added you as a reviewer, to let you give the code a double check since you did the latest sql-refactoring 😄 on my side we're fine and we close the PR 👍

@followynne followynne changed the title Add Sqlite Provider feat(provider): add SQLite sink support Oct 5, 2024
@mo-esmp mo-esmp merged commit 7f4842b into serilog-contrib:master Oct 6, 2024
4 checks passed
@mo-esmp
Copy link
Member

mo-esmp commented Oct 6, 2024

Thanks for the contribution, @techgarage-ir.
@followynne please publish the NuGet package and add me as an owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request .NET Pull requests that update .net code v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants