Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quotes property #110

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Enable quotes property #110

merged 1 commit into from
Feb 7, 2025

Conversation

xiaochengh
Copy link
Contributor

@xiaochengh xiaochengh commented Jan 14, 2025

For servo/servo#34446

Actual behavioral changes are be implemented in servo/servo#34770

Signed-off-by: Xiaocheng Hu <[email protected]>
@mrobinson
Copy link
Member

@xiaochengh Please don't use merge commits. Instead rebase and squash your work into a single commit.

@xiaochengh
Copy link
Contributor Author

Yeah I just noticed that the commits are totally messed up... And it's fixed.

@Loirooriol Loirooriol added this pull request to the merge queue Feb 7, 2025
@Loirooriol
Copy link
Contributor

Loirooriol commented Feb 7, 2025

Yeah I just noticed that the commits are totally messed up

Yes that's because I force-pushed the main branch during an upgrade, this is the approach that we use to avoid diverging from upstream but it has some downsides like messing with existing PRs.

Merged via the queue into servo:main with commit 8af5d51 Feb 7, 2025
3 checks passed
@xiaochengh xiaochengh deleted the enable_quotes branch February 7, 2025 12:56
Loirooriol added a commit that referenced this pull request Feb 11, 2025
Loirooriol added a commit to Loirooriol/servo that referenced this pull request Feb 11, 2025
Bumps Stylo to servo/stylo#110

The actual implementation will happen in servo#34770

Signed-off-by: Oriol Brufau <[email protected]>
github-merge-queue bot pushed a commit to servo/servo that referenced this pull request Feb 11, 2025
Bumps Stylo to servo/stylo#110

The actual implementation will happen in #34770

Signed-off-by: Oriol Brufau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants