Drop Python 3.9 #287
Merged
Drop Python 3.9 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromekelleher
approved these changes
Nov 4, 2024
bio2zarr/vcf2zarr/verification.py
Outdated
| @@ -114,7 +114,7 @@ def assert_format_val_equal(vcf_val, zarr_val, vcf_type, vcf_number): | |||
| assert isinstance(vcf_val, np.ndarray) | |||
| if vcf_type in ("String", "Character"): | |||
| assert len(vcf_val) == len(zarr_val) | |||
| for v, z in zip(vcf_val, zarr_val): | |||
| for v, z in zip(vcf_val, zarr_val, strict=False): | |||
There was a problem hiding this comment.
What's the motivation for the strict=False arguments here and elsewhere? In most of these cases I would have thought we'd want strict=True, so adding the explicit False argument gives a false impression that we expect the iterators to be different lengths.
There was a problem hiding this comment.
Yes, this was automatically fixed by ruff, but you're right that we want strict=True. I've changed this here and in vcztools.
tomwhite
force-pushed
the
drop-python-3.9
branch
from
24957e7
to
c9c7901
Compare
tomwhite
force-pushed
the
drop-python-3.9
branch
from
c9c7901
to
7db7586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.