Teammates contribution 2.5.24 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a Course ID and Course Name -> changed in src/web/app/components/copy-session-modal/__snapshots__/copy-session-modal.component.spec.ts.snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR title: [TEAMMATES#12653] Copy course modal: Mandatory fields not highlighted
Fixes #
TEAMMATES#12653
Outline of Solution
To resolve the issue, I made some changes in the html for copy course modal. Using the alert message HTML code found in the course edit form html, I added some necessary attributes one of which is shown below and "required" which is shown in the input section. The previous PR had missing attributes so this resolved that.
