Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teammates contribution 2.5.24 #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Teammates contribution 2.5.24 #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caab3a4
Updated the Course Copy to include messages stating that they require…
shiishorts Feb 2, 2024
3f48140
Edited the code in copy_course_modal snapshot to better resolve bugs
shiishorts Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...b/app/components/copy-course-modal/__snapshots__/copy-course-modal.component.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,19 @@ exports[`CopyCourseModalComponent should snap when copying from other sessions 1
id="copy-course-id"
maxlength="64"
placeholder="e.g. CS3215-2013Semester1"
required=""
type="text"
/>
<div
class="invalid-field"
hidden=""
>
<i
aria-hidden="true"
class="fa fa-exclamation-circle"
/>
The field Course ID should not be empty.
</div>
<span>
64 characters left
</span>
Expand All @@ -82,8 +93,19 @@ exports[`CopyCourseModalComponent should snap when copying from other sessions 1
id="copy-course-name"
maxlength="80"
placeholder="e.g. Software Engineering"
required=""
type="text"
/>
<div
class="invalid-field"
hidden=""
>
<i
aria-hidden="true"
class="fa fa-exclamation-circle"
/>
The field Course Name should not be empty.
</div>
<span>
80 characters left
</span>
Expand Down