Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override fulcio server secret keys #501

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saisatishkarra
Copy link
Contributor

@saisatishkarra saisatishkarra commented Apr 5, 2023

Description of the change

  1. Override fulcio server secret keys to avoid duplicating the secrets generated in standard TLS format generated by tools like cert-manager
  2. Make the Private Key password as optional since not all secrets are generated to support it.

Existing or Associated Issue(s)

Fix to partially overcome: sigstore/scaffolding#546

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

Signed-off-by: saisatish karra <[email protected]>
@haydentherapper
Copy link
Contributor

Cc @vaikas

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be a breaking change, did you test this upgrade with an existing installation?

@saisatishkarra
Copy link
Contributor Author

@cpanato I haven't verified this change against the existing instance!! can you point me to docs to test it out?

@saisatishkarra
Copy link
Contributor Author

@haydentherapper @cpanato please update the next course of action items if any changes are to be made/tested against to move this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants