Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override fulcio server secret keys #501

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/fulcio/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: |

type: application

version: 2.2.0
version: 2.2.1
appVersion: 1.2.0

keywords:
Expand Down
5 changes: 4 additions & 1 deletion charts/fulcio/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,10 @@ helm uninstall [RELEASE_NAME]
| server.logging.production | bool | `false` | |
| server.name | string | `"server"` | |
| server.replicaCount | int | `1` | |
| server.secret | string | `"fulcio-server-secret"` | |
| server.secret.certificateKey | string | `"cert"` | |
| server.secret.name | string | `"fulcio-server-secret"` | |
| server.secret.passwordKey | string | `"password"` | |
| server.secret.privateKey | string | `"private"` | |
| server.securityContext.runAsNonRoot | bool | `true` | |
| server.securityContext.runAsUser | int | `65533` | |
| server.service.ports[0].name | string | `"http"` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/fulcio/templates/createcerts-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
- name: {{ template "fulcio.createcerts.fullname" . }}
image: "{{ template "fulcio.image" .Values.createcerts.image }}"
imagePullPolicy: "{{ .Values.createcerts.image.pullPolicy }}"
args: ["--secret={{ .Values.server.secret }}"]
args: ["--secret={{ .Values.server.secret.name }}"]
env:
- name: NAMESPACE
valueFrom:
Expand Down
11 changes: 6 additions & 5 deletions charts/fulcio/templates/fulcio-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ spec:
- name: PASSWORD
valueFrom:
secretKeyRef:
name: {{ .Values.server.secret }}
key: password
name: {{ .Values.server.secret.name }}
key: {{ .Values.server.secret.passwordKey }}
optional: true
{{- end }}
volumeMounts:
- name: fulcio-config
Expand Down Expand Up @@ -101,10 +102,10 @@ spec:
{{- if eq .Values.server.args.certificateAuthority "fileca" }}
- name: fulcio-cert
secret:
secretName: {{ .Values.server.secret }}
secretName: {{ .Values.server.secret.name }}
items:
- key: private
- key: {{ .Values.server.secret.privateKey }}
path: key.pem
- key: cert
- key: {{ .Values.server.secret.certificateKey }}
path: cert.pem
{{- end }}
38 changes: 36 additions & 2 deletions charts/fulcio/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -818,8 +818,42 @@
]
},
"secret": {
"type": "string",
"title": "The name of the secret containing the fulcio keys, password and PEM"
"type": "object",
"default": {},
"title": "The secret containing the fulcio sever keys, certificate",
"required": [
"name",
"privateKey",
"certificateKey"
],
"properties": {
"name": {
"type": "string",
"default": "fulcio-server-cert",
"title": "The name of the fulcio secret containing the keys, password, pem",
"examples": [
"fulcio-server-cert"
]
},
"privateKey": {
"type": "string",
"default": "private",
"title": "The key path for private key in secret",
"examples": [
"private",
"tls.key"
]
},
"certificateKey": {
"type": "string",
"default": "cert",
"title": "The key path for certificate PEM in secret",
"examples": [
"cert",
"tls.cert"
]
}
}
}
},
"examples": [
Expand Down
6 changes: 5 additions & 1 deletion charts/fulcio/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ server:
name: server
svcPort: 80
grpcSvcPort: 5554
secret: fulcio-server-secret
secret:
name: fulcio-server-secret
privateKey: private
passwordKey: password
certificateKey: cert
logging:
production: false
image:
Expand Down