Train on all if unspecified

sillsdev · Nov 9, 2023 · b20b4c7 · b20b4c7
1 parent baeba70
commit b20b4c7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Serval.Client/Client.g.cs b/src/Serval.Client/Client.g.cs
@@ -1013,7 +1013,7 @@ public partial interface ITranslationEnginesClient
         /// <br/>you may flag a subset of books for pretranslation by including their [abbreviations](https://github.com/sillsdev/libpalaso/blob/master/SIL.Scripture/Canon.cs)
         /// <br/>in the textIds parameter. If the engine does not support pretranslation, these fields have no effect.
         /// <br/>            
-        /// <br/>Similarly, specify the corpora and textIds to train on. If none are provided, all corpora will be used.
+        /// <br/>Similarly, specify the corpora and textIds to train on. If no train_on field is provided, all corpora will be used.
         /// <br/>            
         /// <br/>The `"options"` parameter of the build config provides the ability to pass build configuration parameters as a JSON object.
         /// <br/>A typical use case would be to set `"options"` to `{"max_steps":10}` in order to configure the maximum
@@ -2916,7 +2916,7 @@ public string BaseUrl
         /// <br/>you may flag a subset of books for pretranslation by including their [abbreviations](https://github.com/sillsdev/libpalaso/blob/master/SIL.Scripture/Canon.cs)
         /// <br/>in the textIds parameter. If the engine does not support pretranslation, these fields have no effect.
         /// <br/>            
-        /// <br/>Similarly, specify the corpora and textIds to train on. If none are provided, all corpora will be used.
+        /// <br/>Similarly, specify the corpora and textIds to train on. If no train_on field is provided, all corpora will be used.
         /// <br/>            
         /// <br/>The `"options"` parameter of the build config provides the ability to pass build configuration parameters as a JSON object.
         /// <br/>A typical use case would be to set `"options"` to `{"max_steps":10}` in order to configure the maximum

diff --git a/src/Serval.Translation/Services/EngineService.cs b/src/Serval.Translation/Services/EngineService.cs
@@ -217,7 +217,7 @@ public async Task<bool> StartBuildAsync(Build build, CancellationToken cancellat
                             if (trainingCorpus.TextIds is not null)
                                 corpus.TrainOnTextIds.Add(trainingCorpus.TextIds);
                         }
-                        else if (trainOn is not null && trainOn.Count == 0)
+                        else if (trainOn is null)
                         {
                             corpus.TrainOnAll = true;
                         }