Refactor how SMuRF operations are called #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
smurf._run_op()
, which provides a convenient way to call any given task in the pysmurf controllers.smurf._run_op()
.tests/util.py
, since several tests are implementing the same thing. Future tests should use this as the "one true mock".CLIENTS
list patch to patch it directly, rather than patching thecreate_clients()
function (which still then requires aninitialize()
is run in every test). This matches the way the wiregrid module patches.This is in advance of work on #94, which requires adding error handling within
_run_op()
.