Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how SMuRF operations are called #108

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Refactor how SMuRF operations are called #108

merged 5 commits into from
Dec 7, 2023

Commits on Dec 7, 2023

  1. Generalize smurf operation calls

    @BrianJKoopman
    BrianJKoopman committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    fdad1f3 View commit details
    Browse the repository at this point in the history

  2. Separate series and parallel logic 

    I had initially wanted to do this before the __getattribute__ usage, but also
when we add additional error handling this'll save us some indentation.
    @BrianJKoopman
    BrianJKoopman committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    1756469 View commit details
    Browse the repository at this point in the history

  3. Check args in test assertions

    @BrianJKoopman
    BrianJKoopman committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    4cd916c View commit details
    Browse the repository at this point in the history

  4. Move mocked client generation for import in all tests

    @BrianJKoopman
    BrianJKoopman committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    72516cb View commit details
    Browse the repository at this point in the history

  5. Patch CLIENTS directly in smurf module tests

    @BrianJKoopman
    BrianJKoopman committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    1142b35 View commit details
    Browse the repository at this point in the history